Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1982] Enable manual triggering for GitHub CI #681

Closed
wants to merge 1 commit into from

Conversation

doupache
Copy link
Contributor

@doupache doupache commented Oct 20, 2023

What is this PR for?

Allow running manually from the github ui.
Everyone can manually run the CI on their fork.

github docs

https://docs.github.com/en/actions/using-workflows/manually-running-a-workflow
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch

What type of PR is it?

  • - Improvement

What is the Jira issue?

YUNIKORN-1982

Screenshots (if appropriate)

Similar to the Apache/Spark benchmark GitHub action, anyone who forks the yunikorn-core repository can execute tests on their own fork. This offers several benefits:

  1. Increased confidence in pull requests.
  2. Enhanced code quality through improved performance and stability.
截圖 2023-10-20 下午6 39 13

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #681 (9dd7f2f) into master (9ad817f) will increase coverage by 0.06%.
Report is 16 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
+ Coverage   77.63%   77.70%   +0.06%     
==========================================
  Files          79       79              
  Lines       13072    13095      +23     
==========================================
+ Hits        10149    10175      +26     
- Misses       2594     2595       +1     
+ Partials      329      325       -4     
Files Coverage Δ
pkg/common/configs/configvalidator.go 92.44% <100.00%> (+0.84%) ⬆️

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pbacsko
Copy link
Contributor

pbacsko commented Oct 22, 2023

+1 LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants