Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1982] Enable manual triggering for GitHub CI #142

Closed
wants to merge 1 commit into from

Conversation

doupache
Copy link
Contributor

What is this PR for?

Allow running manually from the github ui.
Everyone can manually run the CI on their fork.

github docs

https://docs.github.com/en/actions/using-workflows/manually-running-a-workflow
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch

What type of PR is it?

  • - Improvement

What is the Jira issue?

YUNIKORN-1982

Screenshots (if appropriate)

Similar to the Apache/Spark benchmark GitHub action, anyone who forks the yunikorn-web repository can execute tests on their own fork. This offers several benefits:

  1. Increased confidence in pull requests.
  2. Enhanced code quality through improved performance and stability.

This is a pr followed
yunikorn-core 681
yunikorn-site 336
yunikorn-k8shim 706

@craigcondit @pbacsko Please take a look !

@pbacsko pbacsko self-requested a review October 27, 2023 13:27
@codecov-commenter
Copy link

Codecov Report

Merging #142 (6fcf130) into master (d4e85f3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           1        1           
  Lines          30       30           
=======================================
  Hits           20       20           
  Misses          7        7           
  Partials        3        3           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pbacsko pbacsko closed this in 5617efc Oct 27, 2023
@pbacsko pbacsko reopened this Oct 27, 2023
Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pbacsko pbacsko closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants