Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issue): 30131 #31751

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
+16 −2
Open

fix(issue): 30131 #31751

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6ebe11f
fixes for https://github.com/apache/superset/issues/30131
jpchev Jan 8, 2025
b838579
Update Echart.tsx
jpchev Jan 8, 2025
39ba031
Update Echart.tsx
jpchev Jan 8, 2025
82d8c78
Update Echart.tsx
jpchev Jan 8, 2025
16212db
prettier
jpchev Jan 8, 2025
c54ba26
Apply suggestions from code review
jpchev Jan 8, 2025
c4b081c
Update superset-frontend/plugins/plugin-chart-echarts/src/components/…
jpchev Jan 16, 2025
ac15e38
Update superset-frontend/plugins/plugin-chart-echarts/src/components/…
jpchev Jan 16, 2025
9e13ea2
Update Echart.tsx
jpchev Jan 16, 2025
90506f2
prettier
jpchev Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ import {
Ref,
} from 'react';

import { useSelector } from 'react-redux';
import { ExplorePageState } from 'src/explore/types';
import * as echarts from 'echarts/core';
jpchev marked this conversation as resolved.
Show resolved Hide resolved

import { styled } from '@superset-ui/core';
import { use, init, EChartsType } from 'echarts/core';
import {
Expand Down Expand Up @@ -123,10 +127,14 @@ function Echart(
getEchartInstance: () => chartRef.current,
}));

const localeObj = useSelector((state: ExplorePageState) => state?.common?.locale);

This comment was marked as resolved.

Sign in to view

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

This comment was marked as resolved.

Sign in to view

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

const lang = require('echarts/lib/i18n/lang' + localeObj.toUpperCase()).default;

This comment was marked as resolved.

Sign in to view

echarts.registerLocale(localeObj.toUpperCase(), lang);

useEffect(() => {
if (!divRef.current) return;
if (!chartRef.current) {
chartRef.current = init(divRef.current);
chartRef.current = init(divRef.current, undefined, { locale: localeObj });
jpchev marked this conversation as resolved.
Show resolved Hide resolved
}

Object.entries(eventHandlers || {}).forEach(([name, handler]) => {
Expand Down
Loading