fix(issue): 30131 #31751
Open
fix(issue): 30131 #31751
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is to propagate the current locale up to the echarts configuration.
3 tasks
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
 |
Unsafe Dynamic Module Import ▹ view | ✅ |
|
Missing Locale Fallback ▹ view | ✅ |
 |
Missing locale state fallback ▹ view | ✅ |
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Feedback and Support
| @@ -123,10 +127,14 @@ function Echart( | |||
| getEchartInstance: () => chartRef.current, | |||
| })); | |||
|
|
|||
| const localeObj = useSelector((state: ExplorePageState) => state?.common?.locale); | |||
| const lang = require('echarts/lib/i18n/lang' + localeObj.toUpperCase()).default; | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| @@ -123,10 +127,14 @@ | |||
| getEchartInstance: () => chartRef.current, | |||
| })); | |||
|
|
|||
| const localeObj = useSelector((state: ExplorePageState) => state?.common?.locale); | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| @@ -123,10 +127,14 @@ | |||
| getEchartInstance: () => chartRef.current, | |||
| })); | |||
|
|
|||
| const localeObj = useSelector((state: ExplorePageState) => state?.common?.locale); | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
fixes suggested by bot
jpchev
changed the title
removing trailing whitespaces
prettier changes
justinpark
reviewed
Jan 8, 2025
superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: JUST.in DO IT <[email protected]>
9 tasks
There was a problem hiding this comment.
Thank you for submitting this PR @jpchev , you beat me to it :)
With just a few small changes, this is working well for me.
superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx
Outdated
Show resolved
Hide resolved
…Echart.tsx Co-authored-by: Jillian <[email protected]>
…Echart.tsx Co-authored-by: Jillian <[email protected]>
pomegranited
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
👍 This change is working great! Thank you @jpchev :)
- I tested this by combining it with fix(lang): patch FAB's LocaleView to redirect to previous page #31692 to test changing languages while viewing and editing the Pie Chart echart. I verified that this change ensures the "Inv" and "All" buttons on that echart are now translated as expected.
- I read through the code
translate.echarts.mp4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
this is to propagate the current locale up to the echarts configuration.
fixes: #30131
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
switch the locale and verify that charts have the correct locale (for example in months name and in buttons)