Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue-19: embeds must have a line break before and after the url #20

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Issue-19: embeds must have a line break before and after the url #20

merged 4 commits into from
Mar 28, 2024

Conversation

mogmarsh
Copy link
Contributor

@mogmarsh mogmarsh commented Mar 28, 2024 •
edited by alleyinteractive-ops
Loading

Issue Number: #19

Issue URL: embeds must have a line break before and after the url

Description of the Change

  • Fixed an issue where embeds do not display correctly on the front end if they do not have a line break before and after the URL.
  • Implemented preservation of new lines in embed blocks to ensure accurate front-end display.

How to Verify

  1. Convert an embed and view it on the front end.
  2. Edit the block to add line breaks before and after the URL.
  3. Verify that the converted embed retains line breaks and displays correctly.

Additional Notes

No additional notes.

@mogmarsh mogmarsh marked this pull request as ready for review March 28, 2024 12:50
attackant
attackant approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@attackant attackant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question for you, no blockers 🐙

src/class-block-converter.php Show resolved Hide resolved
@mogmarsh mogmarsh merged commit 2145f4b into develop Mar 28, 2024
6 checks passed
@mogmarsh mogmarsh deleted the fix/issue-19/embeds-require-line-breaks-around-url branch March 28, 2024 13:16
juliobranha
juliobranha reviewed Mar 28, 2024
View reviewed changes
Copy link

@juliobranha juliobranha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliobranha juliobranha juliobranha left review comments

@attackant attackant attackant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mogmarsh @attackant @juliobranha