Merge pull request #20 from alleyinteractive/fix/issue-19/embeds-requ…

…ire-line-breaks-around-url

Issue-19: embeds must have a line break before and after the url

CHANGELOG.md

@@ -2,6 +2,11 @@
 
 All notable changes to `WP Block Converter` will be documented in this file.
 
+## 1.3.2
+
+- Preserve new lines in embed blocks. They are required for proper front end rendering.
+- Fix aspect ratio calculation when height and width are percentages - which fixes TikTok embeds.
+
 ## 1.3.1
 
 - Fixes embeds of x.com urls (instead of twitter.com)

src/class-block-converter.php

@@ -67,6 +67,7 @@ public function convert(): string {
 			}
 
 			// Merge the block into the HTML collection.
+
 			$html[] = $this->minify_block( (string) $tag_block );
 		}
 
@@ -274,7 +275,7 @@ protected function embed( string $url ): Block {
 		$data = _wp_oembed_get_object()->get_data( $url, [] );
 
 		$aspect_ratio = '';
-		if ( ! empty( $data->height ) && ! empty( $data->width ) ) {
+		if ( ! empty( $data->height ) && ! empty( $data->width ) && is_numeric( $data->height ) && is_numeric( $data->width ) ) {
 			if ( 1.78 === round( $data->width / $data->height, 2 ) ) {
 				$aspect_ratio = '16-9';
 			}
@@ -446,8 +447,13 @@ public static function get_node_tag_from_html( $html, $tag = 'body' ) {
 	 * @return string
 	 */
 	protected function minify_block( $block ) {
-		if ( preg_match( '/(\s){2,}/s', $block ) === 1 ) {
-			return preg_replace( '/(\s){2,}/s', '', $block );
+		if ( \str_contains( $block, 'wp-block-embed' ) ) {
+			$pattern = '/(\h){2,}/s';
+		} else {
+			$pattern = '/(\s){2,}/s';
+		}
+		if ( preg_match( $pattern, $block ) === 1 ) {
+			return preg_replace( $pattern, '', $block );
 		}
 
 		return $block;