fix tiktok support

alleyinteractive · Mar 28, 2024 · 385ba6d · 385ba6d
1 parent 30fb062
commit 385ba6d
Show file tree

Hide file tree

Showing 3 changed files with 143 additions and 129 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@ All notable changes to `WP Block Converter` will be documented in this file.
 ## 1.3.2
 
 - Preserve new lines in embed blocks. They are required for proper front end rendering.
+- Fix aspect ratio calculation when height and width are percentages - which fixes TikTok embeds.
 
 ## 1.3.1
 

diff --git a/src/class-block-converter.php b/src/class-block-converter.php
@@ -275,7 +275,7 @@ protected function embed( string $url ): Block {
 		$data = _wp_oembed_get_object()->get_data( $url, [] );
 
 		$aspect_ratio = '';
-		if ( ! empty( $data->height ) && ! empty( $data->width ) ) {
+		if ( ! empty( $data->height ) && ! empty( $data->width ) && is_numeric( $data->height ) && is_numeric( $data->width ) ) {
 			if ( 1.78 === round( $data->width / $data->height, 2 ) ) {
 				$aspect_ratio = '16-9';
 			}