Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Add placeholder for failed test without message field #1940

Merged
merged 2 commits into from
Dec 19, 2024
Merged

[Improvement] Add placeholder for failed test without message field #1940

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd364ab
Add placeholder for failed test without error
svenvg93 Dec 18, 2024
cd4d442
Merge branch 'main' into placeholder-failed-tests
svenvg93 Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/Helpers/Ookla.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ public static function getErrorMessage(ProcessFailedException $exception): strin
return $decoded['message'];
}

return ''; // If it's not valid JSON or doesn't contain "message", return an empty string
// Placeholder for invalid JSON or missing "message"
return 'An unexpected error occurred while running the Ookla CLI.';
}, $messages);

// Filter out empty messages and concatenate
Expand Down