Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Add placeholder for failed test without message field #1940

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

svenvg93
Copy link
Contributor

@svenvg93 svenvg93 commented Dec 18, 2024

📃 Description

Sometimes, the Ookla CLI fails to execute the test due to an unknown error. Unfortunately, in such cases, the CLI does not return a complete JSON error response. Instead, it only provides:

{
    "error": "Cannot read: "
}

Our current logic expects a complete JSON response containing a message field. This PR introduces a placeholder error message for these cases, ensuring that failed tests are not left without an error message.

As we cannot do anything about the reason of the failure this;

🪵 Changelog

➕ Added

  • A placeholder message for failed cases without a message field.

@alexjustesen alexjustesen merged commit c37f0bd into alexjustesen:main Dec 19, 2024
1 check passed
@svenvg93 svenvg93 deleted the placeholder-failed-tests branch December 19, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed run has no log or information Resource Temporarily Unavailable
2 participants