RSS feed fixes #28
Open
RSS feed fixes #28
+114
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msurdi
commented
Nov 1, 2024
| @@ -16,11 +16,11 @@ | |||
| @each(post in blogPosts) | |||
| <item> | |||
| <title><![CDATA[{{ post.title }}]]></title> | |||
| <link>{{ route('blog.show', [post.slug]) }}</link> | |||
| <guid>{{ post.slug }}</guid> | |||
| <link>https://adonisjs.com{{ route('blog.show', [post.slug]) }}</link> | |||
There was a problem hiding this comment.
Is this the best way to get an absolute URL containing the right domain?
msurdi
commented
Nov 1, 2024
| <pubDate>{{ post.publishedAt }}</pubDate> | ||
| <description><![CDATA[ {{{ post.contentHtml.summary }}} ]]></description> | ||
| <content:encoded><![CDATA[ {{{ post.contentHtml.contents }}} ]]></content:encoded> | ||
| <description><![CDATA[ {{{ sanitize(post.contentHtml.summary) }}} ]]></description> |
There was a problem hiding this comment.
Sanitization is necessary so that we don't include dangerous elements in the output, such as script tags, etc. This solves almost all of the content related warnings in the validation tool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#19 (comment)
❓ Type of change
📚 Description
As described in #19 (comment), after we've implemented the RSS feed for the blog entries, we found a few validation issues and some warnings.
This PR solves the main feed validation problems and addresses most of the warnings.
The only remaining warning is about having relative URLs within the posts contents. I don't think there's much we can do without hacky string manipulations to resolve this from the feed point of view.
📝 Checklist