-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RSS support for Blog entries #19
Conversation
Cool thing to have! Thanks for the PR Looks good to me. @thetutlage any thoughts ? |
Hey @msurdi! ππ» Thanks for this PR. Since we are dumping the whole article content, the file will probably grow big. Wouldn't it be better only to display the title and a summary? |
Hi @RomainLanz! Thanks a lot for taking some time to review this. I think it's nice to have the full article, so that you can read the posts without leaving your news reader. But I agree the size of this can get quickly out of hand. I've just pushed a commit where I instead limited the number of posts to the latest 20 available. Would that work? I'm happy to truncate the content if you still think it's necessary and there's no way around that. Thanks! |
I think its fine to have all the contents for now, since we don't have many posts. Later we can see if we want to something different once we start to hit any sort of limits |
We will also have to update the |
Agreed. One question though: do most RSS readers support JavaScript? Since we might have custom components in those articles, they could potentially break in RSS readers if JavaScript isnβt handled. |
To be honest, I have not used any RSS readers recently. So yeah, we should give a test run once and see what the ideal experience will be |
@thetutlage I've just added the static generation step for the feed. Let me know if there is anything else I can do here. Thanks π |
Co-authored-by: Romain Lanz <[email protected]>
Co-authored-by: Romain Lanz <[email protected]>
Co-authored-by: Romain Lanz <[email protected]>
All suggested changes applied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! |
It looks like the generated feed has some issues: https://www.rssboard.org/rss-validator/check.cgi?url=https%3A%2F%2Fadonisjs.com%2F Can you have a look at it? @msurdi |
Sure, Iβll check this over the weekend. |
@RomainLanz just opened #28 to address these issues. |
π Linked issue
β Type of change
π Description
I wanted to subscribe to your blog using an RSS feed reader and noticed there was no feed for the blog. Here's a quick implementation for adding it.
π Checklist