Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(breaking-change): update for nodes 18 and 20 #127

Merged
merged 6 commits into from
Nov 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/app-smoke-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ jobs:
strategy:
max-parallel: 1
matrix:
node: [14, 16]
node-version: [18.x, 20.x]
os: [ubuntu-latest]

steps:
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
node-version: ${{ matrix.node-version }}
- name: Setup CLI
uses: actions/checkout@master
with:
Expand Down Expand Up @@ -112,5 +112,5 @@ jobs:
env:
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
SLACK_TITLE: 'Node version'
SLACK_MESSAGE: ${{ matrix.node }}
SLACK_MESSAGE: ${{ matrix.node-version }}
SLACK_COLOR: ${{ job.status == 'success' && 'good' || job.status == 'cancelled' && '#808080' || 'danger' }}
12 changes: 6 additions & 6 deletions .github/workflows/app-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node: [16.7.0]
node-version: [18]
os: [ubuntu-latest]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node }}
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node }}
node-version: ${{ matrix.node-version }}
- run: npm i --package-lock --package-lock-only
- run: npm ci
- name: Run E2E Tests
Expand Down Expand Up @@ -48,20 +48,20 @@ jobs:
run: |
git config user.name github-actions
git config user.email [email protected]
echo "- $(date) Node ${{ matrix.node }} ${{ job.status == 'success' && '🎉 success' || job.status }}" >> logs/run.md
echo "- $(date) Node ${{ matrix.node-version }} ${{ job.status == 'success' && '🎉 success' || job.status }}" >> logs/run.md
git add logs/run.md
git commit -m "generated"
git push
- name: Upload Coverage
if: ${{ success() && (github.event_name == 'pull_request' || github.event_name == 'push') }}
uses: codecov/[email protected]
with:
name: ${{ runner.os }} node.js ${{ matrix.node }}
name: ${{ runner.os }} node.js ${{ matrix.node-version }}
- name: Slack Notification
if: ${{ failure() && (github.event_name == 'schedule' || github.event_name == 'workflow_dispatch') }}
uses: rtCamp/action-slack-notify@v2
env:
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
SLACK_TITLE: 'Node version'
SLACK_MESSAGE: ${{ matrix.node }}
SLACK_MESSAGE: ${{ matrix.node-version }}
SLACK_COLOR: ${{ job.status == 'success' && 'good' || job.status == 'cancelled' && '#808080' || 'danger' }}
4 changes: 2 additions & 2 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node-version: [16.x]
node-version: [18.x]
os: [ubuntu-latest, windows-latest]

steps:
Expand All @@ -33,4 +33,4 @@ jobs:
if: success()
uses: codecov/[email protected]
with:
name: ${{ runner.os }} node.js ${{ matrix.node-version }}
name: ${{ runner.os }} node.js ${{ matrix.node-version }}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,6 @@
"typescript": "^5.1.6"
},
"engines": {
"node": ">=16.0.0"
"node": ">=8.3.0"
}
}
Loading