Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(breaking-change): update for nodes 18 and 20 #127

Merged
merged 6 commits into from
Nov 23, 2023
Merged

Conversation

shazron
Copy link
Member

@shazron shazron commented Nov 14, 2023

Closes #128

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4eb3dfb) 100.00% compared to head (66a3e67) 100.00%.
Report is 39 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #127   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          161       161           
  Branches        44        44           
=========================================
  Hits           161       161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shazron
Copy link
Member Author

shazron commented Nov 21, 2023

Fix #128

@MichaelGoberling MichaelGoberling self-requested a review November 21, 2023 14:56
@shazron shazron merged commit c73c613 into master Nov 23, 2023
5 checks passed
@shazron shazron deleted the update-node-18-20 branch November 23, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support node version >= 8.3.0
4 participants