Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that content-length header can never be deleted #504

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Make sure that content-length header can never be deleted #504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/controllers/tracks_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,10 @@ def audio_with_stream(stream, mimetype, total_size)
response.content_type = mimetype
response.headers['accept-ranges'] = 'bytes'
response.headers['content-length'] = (last_byte - first_byte + 1).to_s
# Unfortunately, if we don't commit the headers, ActionController::Live will
# delete the "content-length" header set above. No other headers need to be
# set, so we just freeze them here.
response.commit!

to_skip = first_byte
while to_skip.positive?
Expand Down