Make sure that content-length header can never be deleted #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once the response is `commit`ted, the headers can't be edited anymore, which is exactly what we want in this case.
chvp
force-pushed
the
fix/streaming-content-length
branch
from
b997a39 to
c410fdc
Compare
|
(I've already applied this fix in our production instance, because it was quite annoying.) |
robbevp
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the response is
committed, the headers can't be edited anymore, which is exactly what we want in this case.Unfortunately, this can't be added to the tests, because the way responses and
ActionController::Livework in tests just doesn't allow it (in fact, the tests already "test" for the presence of this header, and the tests still succeed even though in production the header is not present).Fixes #503.