Conditional notice #658
Merged
Conditional notice #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomNaessens
commented
Nov 27, 2022
|
Would be nice to get this one closed. Are the comments deal breaking, or just nice to haves? |
|
@mcbloch Yes, they are dealbreaking. Will have to be rebased too |
xerbalind
force-pushed
the
conditional-notice
branch
from
286766a to
2b3a6e3
Compare
xerbalind
force-pushed
the
conditional-notice
branch
from
2b3a6e3 to
955cc9d
Compare
TomNaessens
force-pushed
the
conditional-notice
branch
from
955cc9d to
7f1d065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #480