Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the bank-payment notice when a free ticket is selected #480

Closed
TomNaessens opened this issue Mar 12, 2015 · 2 comments · Fixed by #658
Closed

Remove the bank-payment notice when a free ticket is selected #480

TomNaessens opened this issue Mar 12, 2015 · 2 comments · Fixed by #658
Assignees
@BrentyMcFatty
Labels
enhancement first-good-issue Good for newcomers level: easy Small/easy issue fixable in an evening

Comments

@TomNaessens
Copy link
Member

No description provided.

@NuttyShrimp NuttyShrimp added enhancement level: easy Small/easy issue fixable in an evening first-good-issue Good for newcomers and removed easy labels Oct 3, 2022
@BrentyMcFatty BrentyMcFatty self-assigned this Oct 28, 2022
@BrentyMcFatty
Copy link
Contributor

BrentyMcFatty commented Nov 25, 2022 •
edited
Loading

fbb0cd1 :
Dit is de eerste volle functionele commit,
waarbij je de bug hebt dat als je een € in de naam van je event zet, de payment notice nog altijd verschijnt, ook al is de event gratis (is 'event' nu onzijdig of niet?)

286766a :
Dit is de commit waarbij ik probeerde de bug eruit te krijgen, en ik vrij zeker ben dat ik op het juiste spoor zit. Maar ik ken de precieze syntax van ruby niet, dus ik ben er niet geraakt na veel proberen. Hierbij zou ik graag wat hulp krijgen.

@TomNaessens TomNaessens mentioned this issue Nov 27, 2022
Merged
@TomNaessens
Copy link
Member Author

TomNaessens commented Nov 27, 2022 •
edited
Loading

Create #658 for easier review comments

Looks good on first sight, only the querying can be improved a bit, as you mentioned. The guides are pretty good to find what you need: https://guides.rubyonrails.org/active_record_querying.html#array-conditions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrentyMcFatty BrentyMcFatty

Labels
enhancement first-good-issue Good for newcomers level: easy Small/easy issue fixable in an evening
Projects
Open Issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Conditional notice ZeusWPI/Gandalf
3 participants
@TomNaessens @NuttyShrimp @BrentyMcFatty