feat: improving PR experience with comments #44
pull-request.yml
on: pull_request
Check the code quality
2m 20s
Deploy preview version of the storybook on firebase
0s
Annotations
3 errors and 1 warning
Check the code quality:
src/components/fab/fab.ts#L1
'nothing' is declared but its value is never read.
|
Check the code quality
> @zebra-fed/[email protected] prepare
> npm run build
> @zebra-fed/[email protected] prebuild
> npm run analyze && node scripts/make-index.js
> @zebra-fed/[email protected] analyze
> cem analyze
[custom-jsdoc-tags] - Updating Custom Elements Manifest...
[cem-expanded-types] - Custom Elements Manifest updated.
[3:58:41 PM] @custom-elements-manifest/analyzer: Created new manifest.
> @zebra-fed/[email protected] build
> tsc -P tsconfig.build.json && npx clean-css-cli ./src/index.css -o ./dist/index.css
src/components/fab/fab.ts(1,16): error TS6133: 'nothing' is declared but its value is never read.
|
Check the code quality
> @zebra-fed/[email protected] test
> web-test-runner "src/test/**/*.test.ts" --node-resolve
Chromium: |█▎ | 0/46 test files | 0 passed, 0 failed
Running tests...
Running 46 test files...
�[2K�[1A�[2K�[G4:00:21 PM [vite] (client) ✨ new dependencies optimized: @web/test-runner-commands, @zebra-fed/zeta-icons
4:00:21 PM [vite] (client) ✨ optimized dependencies changed. reloading
�[2K�[1A�[2K�[Gsrc/test/bottom-sheets/bottom-sheet.test.ts:
🚧 Browser logs:
Multiple versions of Lit loaded. Loading multiple versions is not recommended. See https://lit.dev/msg/multiple-versions for more information.
�[2K�[1A�[2K�[G4:00:23 PM [vite] (client) ✨ new dependencies optimized: lit/directives/live.js
4:00:23 PM [vite] (client) ✨ optimized dependencies changed. reloading
�[2K�[1A�[2K�[Gsrc/test/dialog/dialog.test.ts:
🚧 Browser logs:
Multiple versions of Lit loaded. Loading multiple versions is not recommended. See https://lit.dev/msg/multiple-versions for more information.
�[2K�[1A�[2K�[Gsrc/test/checkbox/checkbox.test.ts:
🚧 Browser logs:
Multiple versions of Lit loaded. Loading multiple versions is not recommended. See https://lit.dev/msg/multiple-versions for more information.
Element zeta-checkbox scheduled an update (generally because a property was set) after an update completed, causing a new update to be scheduled. This is inefficient and should be avoided unless the next update can only be scheduled as a side effect of the previous update. See https://lit.dev/msg/change-in-update for more information.
�[2K�[1A�[2K�[Gsrc/test/dropdown/dropdown-menu-button.test.ts:
🚧 Browser logs:
Element zeta-checkbox scheduled an update (generally because a property was set) after an update completed, causing a new update to be scheduled. This is inefficient and should be avoided unless the next update can only be scheduled as a side effect of the previous update. See https://lit.dev/msg/change-in-update for more information.
Element zeta-radio-button scheduled an update (generally because a property was set) after an update completed, causing a new update to be scheduled. This is inefficient and should be avoided unless the next update can only be scheduled as a side effect of the previous update. See https://lit.dev/msg/change-in-update for more information.
�[2K�[1A�[2K�[Gsrc/test/fab/fab.test.ts:
❌ zeta-fab > Content Tests > renders a button with a label
AssertionError: expected null to exist
at n.<anonymous> (src/test/fab/fab.test.ts?wtr-session-id=YrgYzsy-46_TfRIuKHimU:35:61)
❌ zeta-fab > Content Tests > renders an extended fab
AssertionError: expected null to exist
at n.<anonymous> (src/test/fab/fab.test.ts?wtr-session-id=YrgYzsy-46_TfRIuKHimU:54:34)
❌ zeta-fab > Content Tests > renders a default fab
AssertionError: expected null to exist
at n.<anonymous> (src/test/fab/fab.test.ts?wtr-session-id=YrgYzsy-46_TfRIuKHimU:63:30)
�[2K�[1A�[2K�[G4:00:25 PM [vite] (client) ✨ new dependencies optimized: @lit/localize
4:00:25 PM [vite] (client) ✨ optimized dependencies changed. reloading
�[2K�[1A�[2K�[G4:00:26 PM [vite] (client) ✨ new dependencies optimized: lit/directives/unsafe-svg.js
4:00:26 PM [vite] (client) ✨ optimized dependencies changed. reloading
�[2K�[1A�[2K�[Gsrc/test/navigation-drawer-footer/navigation-drawer-foote
|
Check the code quality
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|