Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improving PR experience with comments #6

Open
wants to merge 85 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
85 commits
Select commit Hold shift + click to select a range
5724312
feat: added post coverage comment github PR
DE7924 Dec 4, 2024
41baea6
BREAKING CHANGE
DE7924 Dec 4, 2024
0b4649e
steps > jobs
DE7924 Dec 4, 2024
baa261e
added ids
DE7924 Dec 4, 2024
fa04bbe
replace old comment
DE7924 Dec 4, 2024
3919f2d
reverted fab
DE7924 Dec 4, 2024
020eeaf
commented out avatar to test action
DE7924 Dec 4, 2024
ea678e4
changed git ignore so that coverage can be seen by github action
DE7924 Dec 4, 2024
8271d24
removed ##
DE7924 Dec 4, 2024
f79c19f
debugging
DE7924 Dec 4, 2024
42cf770
reverted gitignore
DE7924 Dec 4, 2024
bbc7712
removed coverage
DE7924 Dec 4, 2024
0af1c0f
removed some test from fab to test code coverage comment
DE7924 Dec 4, 2024
726b161
reverted fab change
DE7924 Dec 4, 2024
cfb5243
broken fab
DE7924 Dec 4, 2024
aa3dceb
added fall back to post failure comment
DE7924 Dec 4, 2024
984aa9b
removed slippery semi colon
DE7924 Dec 4, 2024
dc71dcf
cleaned up comment
DE7924 Dec 4, 2024
c588686
further cleaning
DE7924 Dec 4, 2024
eb5592e
codeql comment test
DE7924 Dec 5, 2024
3751b75
added quotes
DE7924 Dec 5, 2024
d9fdb87
checking db-locations
DE7924 Dec 5, 2024
04cf9e9
combined both comments
DE7924 Dec 5, 2024
bb367ee
updated names
DE7924 Dec 5, 2024
205a28a
remove chart column
DE7924 Dec 5, 2024
7db1dee
remove header
DE7924 Dec 5, 2024
2887ad6
changed " to '
DE7924 Dec 5, 2024
83b1135
testing new github action
DE7924 Dec 13, 2024
6cc67a2
update code quality action version
DE7924 Dec 13, 2024
8db5785
changed version
DE7924 Dec 13, 2024
1bd5a4e
testing failure
DE7924 Dec 13, 2024
4505385
v0.0.4
DE7924 Dec 13, 2024
ec92048
v.5
DE7924 Dec 13, 2024
701cfd7
v6
DE7924 Dec 13, 2024
691b08a
1.1.6
DE7924 Dec 13, 2024
58664d0
v.7
DE7924 Dec 13, 2024
4f24338
v.8
DE7924 Dec 13, 2024
e593422
v.9
DE7924 Dec 13, 2024
fd61e76
added eslint problem
DE7924 Dec 13, 2024
330aad6
breaking lit-analyzer
DE7924 Dec 18, 2024
aa62441
lit no missing import
DE7924 Dec 18, 2024
c909fce
turn off --quiet on lit-analyzer
DE7924 Dec 18, 2024
d33a2b0
v1.2.0
DE7924 Dec 18, 2024
d723b9d
add back import
DE7924 Dec 18, 2024
d9b3f2d
v1.2.1
DE7924 Dec 18, 2024
d340cfd
.2.2
DE7924 Dec 18, 2024
a4bd1d9
.2.4
DE7924 Dec 18, 2024
01dcb5f
.2.5
DE7924 Dec 19, 2024
7426e06
.2.6
DE7924 Dec 19, 2024
6337e47
.2.7
DE7924 Dec 19, 2024
653624c
.2.8
DE7924 Dec 19, 2024
53b6463
v.2.9
DE7924 Dec 20, 2024
0502b7a
v.3.0
DE7924 Dec 20, 2024
e42ae2e
reset fab
DE7924 Dec 20, 2024
26d14aa
removed change
DE7924 Dec 20, 2024
0384d3e
action-setup
DE7924 Dec 20, 2024
944ab76
check modified files command
DE7924 Dec 20, 2024
3b32281
[automated commit] lint format and import sort
invalid-email-address Dec 20, 2024
4b68f5d
Generated locales
invalid-email-address Dec 20, 2024
36aa895
[automated commit] lint format and import sort
invalid-email-address Dec 20, 2024
9232c20
Generated locales
invalid-email-address Dec 20, 2024
4b407c0
[automated commit] lint format and import sort
invalid-email-address Dec 20, 2024
2049d29
Generated locales
invalid-email-address Dec 20, 2024
dea0213
run code formatting = false
DE7924 Dec 20, 2024
f30a24a
Merge branch 'improve-pr-experience' of https://github.com/ZebraDevs/…
DE7924 Dec 20, 2024
4cbce66
remove format option
DE7924 Dec 20, 2024
6fd062f
[automated commit] lint format and import sort
invalid-email-address Dec 20, 2024
f2e38b4
Generated locales
invalid-email-address Dec 20, 2024
77dc655
[automated commit] lint format and import sort
invalid-email-address Dec 23, 2024
6c5cfc8
added @web/dev-server-esbuild
DE7924 Dec 23, 2024
167aa06
Merge branch 'improve-pr-experience' of https://github.com/ZebraDevs/…
DE7924 Dec 23, 2024
db5d74a
configured web test runner
DE7924 Dec 23, 2024
1e8cc9a
revert web-test-runner config
DE7924 Dec 23, 2024
9601201
[automated commit] lint format and import sort
invalid-email-address Dec 23, 2024
e42b8c7
configure web test runner with junit reporter
DE7924 Dec 23, 2024
fe5ad61
Merge branch 'improve-pr-experience' of https://github.com/ZebraDevs/…
DE7924 Dec 23, 2024
91288b0
[automated commit] lint format and import sort
invalid-email-address Dec 23, 2024
d608e88
[automated commit] lint format and import sort
invalid-email-address Dec 23, 2024
ce07895
[automated commit] lint format and import sort
invalid-email-address Dec 23, 2024
29a98af
[automated commit] lint format and import sort
invalid-email-address Dec 23, 2024
992800f
[automated commit] lint format and import sort
invalid-email-address Dec 23, 2024
57fbf3b
[automated commit] lint format and import sort
invalid-email-address Dec 23, 2024
f5d310d
test
DE7924 Dec 23, 2024
2d448b8
[automated commit] lint format and import sort
invalid-email-address Dec 23, 2024
e92b940
[automated commit] lint format and import sort
invalid-email-address Dec 23, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 5 additions & 44 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,51 +22,12 @@ jobs:
with:
node-version: 18.x.x
cache: "npm"
- name: Install dependencies
run: npm ci
- name: Store Playwright's Version
id: store-playwright-version
run: |
PLAYWRIGHT_VERSION=$(npm ls @playwright/test | grep @playwright | sed 's/.*@//')
echo "Playwright's Version: $PLAYWRIGHT_VERSION"
echo "PLAYWRIGHT_VERSION=$PLAYWRIGHT_VERSION" >> $GITHUB_ENV
- name: Cache Playwright Browsers for Playwright's Version
id: cache-playwright-browsers
uses: actions/cache@v3
env:
PLAYWRIGHT_VERSION: ${{ steps.store-playwright-version.outputs.PLAYWRIGHT_VERSION }}
if: env.PLAYWRIGHT_VERSION == 'true'
- name: Code Quality
uses: ZebraDevs/web-components-code-quality@action-setup
with:
path: ~/.cache/ms-playwright
key: playwright-browsers-${{ env.PLAYWRIGHT_VERSION }}
- name: Install playwright browsers
if: steps.cache-playwright-browsers.outputs.cache-hit != 'true'
run: npx playwright install --with-deps
- name: Run custom elements manifest analyzer
run: npm run analyze
- name: Run eslint
run: npm run lint
- name: Run prettier
run: npm run prettier
- name: Run lit-analyzer
run: npm run lint:lit-analyzer
- name: Run tests
run: npm run test -- --debug
- name: Test tsdoc
run: npm run docs
- name: Check for modified files
id: git-check
run: echo "modified=$(if [ -n "$(git status --porcelain)" ]; then echo "true"; else echo "false"; fi)" >> $GITHUB_ENV
- name: Update changes in GitHub repository
env:
MODIFIED: ${{ steps.git-check.outputs.modified }}
if: env.MODIFIED == 'true'
run: |
git config --global user.name "github-actions"
git config --global user.email "[email protected]"
git add -A
git commit -m '[automated commit] lint format and import sort'
git push
token: ${{ secrets.GITHUB_TOKEN }}
test-results-path: "src/test/test-results.xml"

generate-localizations:
name: Generate localizations.
needs: [code-quality]
Expand Down
2,002 changes: 232 additions & 1,770 deletions package-lock.json

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -111,13 +111,15 @@
"storybook": "^8.4.4",
"ts-lit-plugin": "^2.0.2",
"ts-morph": "^24.0.0",
"typedoc": "^0.27.4",
"typescript": "^5.7.2",
"typescript-eslint": "^8.16.0",
"vite": "^6.0.2"
},
"dependencies": {
"@fontsource/ibm-plex-sans": "^5.0.21",
"@lit/localize": "^0.12.2",
"@web/test-runner-junit-reporter": "^0.7.2",
"@zebra-fed/zeta-icons": "^0.9.0",
"lit": "^3.2.1"
},
Expand Down
2 changes: 1 addition & 1 deletion src/components/dialog/dialog.styles.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,4 +114,4 @@ export default css`
zeta-icon {
--icon-size: 32px;
}
`;
`;
2 changes: 1 addition & 1 deletion src/components/dialog/dialog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -136,4 +136,4 @@ declare global {
interface HTMLElementTagNameMap {
"zeta-dialog": ZetaDialog;
}
}
}
20 changes: 15 additions & 5 deletions src/components/fab/fab.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,18 +55,28 @@ export class ZetaFab extends Flavored(BaseButton) {

@property({ type: String, reflect: true }) size: "small" | "large" = "small";

private getLabel() {
return this.label ? html`<div class="label">${this.label}</div>` : nothing;
}
// TESTING
protected render() {
return html`
<button ?disabled=${this.disabled} value=${ifDefined(this.value)} name=${ifDefined(this.name)} type=${ifDefined(this.type)}>
<zeta-icon .rounded=${this.rounded}><slot></slot></zeta-icon>
${this.extended ? this.getLabel() : nothing}
</button>
${this.extended ? nothing : this.getLabel()}
`;
}
// TESTING END

// private getLabel() {
// return this.label ? html`<div class="label">${this.label}</div>` : nothing;
// }
// protected render() {
// return html`
// <button ?disabled=${this.disabled} value=${ifDefined(this.value)} name=${ifDefined(this.name)} type=${ifDefined(this.type)}>
// <zeta-icon .rounded=${this.rounded}><slot></slot></zeta-icon>
// ${this.extended ? this.getLabel() : nothing}
// </button>
// ${this.extended ? nothing : this.getLabel()}
// `;
// }
}

declare global {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export default css`
display: flex;
max-width: 64px;
}
slot{
slot {
font: var(--label-small);
}

Expand All @@ -14,8 +14,6 @@ export default css`
background-color: var(--surface-selected);
}



:host > * {
display: flex;
overflow-x: hidden;
Expand Down
2 changes: 0 additions & 2 deletions src/components/navigation-rail/navigation-rail.styles.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,4 @@ export default css`
::slotted(:not(zeta-navigation-rail-item)) {
display: none;
}


`;
2 changes: 1 addition & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -140,4 +140,4 @@ export {
ZetaTopAppbar,
ZetaUploadItem,
ZetaWorkcloudIndicator
};
};
Loading