Skip to content

feat: improving PR experience with comments #43

feat: improving PR experience with comments

feat: improving PR experience with comments #43

Triggered via pull request December 13, 2024 15:54
Status Failure
Total duration 3m 1s
Artifacts

pull-request.yml

on: pull_request
Check the code quality
2m 48s
Check the code quality
Generate localizations.
0s
Generate localizations.
Deploy preview version of the storybook on firebase
0s
Deploy preview version of the storybook on firebase
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 1 warning
Check the code quality: src/components/fab/fab.ts#L1
'nothing' is declared but its value is never read.
Check the code quality
> @zebra-fed/[email protected] prepare > npm run build > @zebra-fed/[email protected] prebuild > npm run analyze && node scripts/make-index.js > @zebra-fed/[email protected] analyze > cem analyze [custom-jsdoc-tags] - Updating Custom Elements Manifest... [cem-expanded-types] - Custom Elements Manifest updated. [3:54:33 PM] @custom-elements-manifest/analyzer: Created new manifest. > @zebra-fed/[email protected] build > tsc -P tsconfig.build.json && npx clean-css-cli ./src/index.css -o ./dist/index.css src/components/fab/fab.ts(1,16): error TS6133: 'nothing' is declared but its value is never read.
Check the code quality
> @zebra-fed/[email protected] test > web-test-runner "src/test/**/*.test.ts" --node-resolve Chromium: |█▎ | 0/46 test files | 0 passed, 0 failed Running tests... Running 46 test files... �[2K�[1A�[2K�[G3:56:30 PM [vite] (client) ✨ new dependencies optimized: @web/test-runner-commands, @zebra-fed/zeta-icons 3:56:30 PM [vite] (client) ✨ optimized dependencies changed. reloading �[2K�[1A�[2K�[G3:56:32 PM [vite] (client) ✨ new dependencies optimized: lit/directives/live.js 3:56:32 PM [vite] (client) ✨ optimized dependencies changed. reloading �[2K�[1A�[2K�[Gsrc/test/checkbox/checkbox.test.ts: 🚧 Browser logs: Multiple versions of Lit loaded. Loading multiple versions is not recommended. See https://lit.dev/msg/multiple-versions for more information. Element zeta-checkbox scheduled an update (generally because a property was set) after an update completed, causing a new update to be scheduled. This is inefficient and should be avoided unless the next update can only be scheduled as a side effect of the previous update. See https://lit.dev/msg/change-in-update for more information. �[2K�[1A�[2K�[Gsrc/test/dropdown/dropdown-menu-button.test.ts: 🚧 Browser logs: Element zeta-checkbox scheduled an update (generally because a property was set) after an update completed, causing a new update to be scheduled. This is inefficient and should be avoided unless the next update can only be scheduled as a side effect of the previous update. See https://lit.dev/msg/change-in-update for more information. Element zeta-radio-button scheduled an update (generally because a property was set) after an update completed, causing a new update to be scheduled. This is inefficient and should be avoided unless the next update can only be scheduled as a side effect of the previous update. See https://lit.dev/msg/change-in-update for more information. �[2K�[1A�[2K�[G3:56:34 PM [vite] (client) ✨ new dependencies optimized: @lit/localize 3:56:34 PM [vite] (client) ✨ optimized dependencies changed. reloading �[2K�[1A�[2K�[Gsrc/test/fab/fab.test.ts: ❌ zeta-fab > Content Tests > renders a button with a label AssertionError: expected null to exist at n.<anonymous> (src/test/fab/fab.test.ts?wtr-session-id=Wun7z0gaO5pPG7QirotbP:35:61) ❌ zeta-fab > Content Tests > renders an extended fab AssertionError: expected null to exist at n.<anonymous> (src/test/fab/fab.test.ts?wtr-session-id=Wun7z0gaO5pPG7QirotbP:54:34) ❌ zeta-fab > Content Tests > renders a default fab AssertionError: expected null to exist at n.<anonymous> (src/test/fab/fab.test.ts?wtr-session-id=Wun7z0gaO5pPG7QirotbP:63:30) �[2K�[1A�[2K�[G3:56:36 PM [vite] (client) ✨ new dependencies optimized: lit/directives/unsafe-svg.js 3:56:36 PM [vite] (client) ✨ optimized dependencies changed. reloading �[2K�[1A�[2K�[Gsrc/test/navigation-drawer-footer/navigation-drawer-footer.test.ts: 🚧 Browser logs: Multiple versions of Lit loaded. Loading multiple versions is not recommended. See https://lit.dev/msg/multiple-versions for more information. �[2K�[1A�[2K�[Gsrc/test/navigation-drawer/navigation-drawer.test.ts: 🚧 Browser logs: Multiple versions of Lit loaded. Loading multiple versions is not recommended. See https://lit.dev/msg/multiple-versions for more information. �[2K�[1A�[2K�[G3:56:39 PM �
Check the code quality
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636