[ROS-O] drop obsolete use of boost::bind and _1 #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lambdas are preferred since c++11. The transitively included use of _1 starts failing with a recently proposed change to adapt the boost-bind include API in ros_comm. ros-o/ros_comm#3
default almost everywhere and log4cxx breaks without 17 support for years.
... where there is no package. Only a script was installed from the setup.py but catkin provides a separate command for that http://docs.ros.org/en/jade/api/catkin/html/howto/format2/installing_python.html I retained the installation to the global path. It is unusual to do that, but it has been like that for a long time. This started failing with recent setuptools with the following error message: --- error: Multiple top-level packages discovered in a flat-layout: ['debian', 'config', 'launch']. To avoid accidental inclusion of unwanted files or directories, setuptools will not proceed with this build. If you are trying to create a single distribution with multiple packages on purpose, you should not rely on automatic discovery. Instead, consider the following options: 1. set up custom discovery (`find` directive with `include` or `exclude`) 2. use a `src-layout` 3. explicitly set `py_modules` or `packages` with a list of names To find more information, look for "package discovery" on setuptools docs. ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lambdas are preferred since c++11.
The transitively included use of _1 starts failing with a recently proposed change to adapt the boost-bind include API in ros_comm. ros-o/ros_comm#3