Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate HealthChecks.Milvus tests to Testcontainers #2360

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

Alirexaa
Copy link
Collaborator

@Alirexaa Alirexaa commented Jan 9, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes:
Contributes to #2335
Please reference the issue this PR will close: #[issue number]

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

@github-actions github-actions bot added the github_actions Pull requests that update Github_actions code label Jan 9, 2025
@Alirexaa Alirexaa requested a review from adamsitnik January 9, 2025 13:44
Copy link
Collaborator

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @Alirexaa !

test/HealthChecks.Milvus.Tests/MilvusContainerFixture.cs Outdated Show resolved Hide resolved
@Alirexaa Alirexaa mentioned this pull request Jan 9, 2025
71 tasks
@Alirexaa Alirexaa merged commit 3aee551 into master Jan 9, 2025
57 of 58 checks passed
@Alirexaa Alirexaa deleted the alirexaa/milvus-testcontainr branch January 9, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants