-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to run all tests locally #2335
Comments
It would be nice to be able to run all of them locally. Are there any disadvantages (beside a lot of work) of such approach? |
In my experience, I did not encounter any problems. @adamsitnik If there is not any tip/hint that you mind, I could prepare the initial PR for this issue. |
Could you please try to implement it for one of our health checks (like redis/mongo etc) and send a PR with a short writeup of how does it feel to use it? Like what needs to be installed, how debugging looks like etc? Just so we can all give it a try and agree on the pattern and direction before we apply it to all health checks |
See #2345. |
@adamsitnik, I update the issue description. Let's pick each package one by one and send separate PRs for each of them. |
Some of our tests depend on external services, And they can not run locally unless we manually perform some work.
We configured CI to run these external services.
For example, Milvus uses the docker compose file.
AspNetCore.Diagnostics.HealthChecks/.github/workflows/healthchecks_milvus_ci.yml
Lines 33 to 40 in 78d664e
Elasticsearch is configured by services in actions.
AspNetCore.Diagnostics.HealthChecks/.github/workflows/healthchecks_elasticsearch_ci.yml
Lines 30 to 38 in 78d664e
We should change these tests to use TestContainer like the Aspire team did.
Update
We migrate the
HealthChecks.Redis
tests to Testcontainer in #2345.Let's use that PR as a sample and migrate the other tests.
Check Lists
CC @adamsitnik @eerhardt @unaizorrilla
The text was updated successfully, but these errors were encountered: