Change behavior of --base-commit and --outdated-since options
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walavouchey
approved these changes
Dec 29, 2023
|
does this need changes |
|
yeah, because base-commit is different now the new default options are the intended ones for both CI and run_checks |
Walavouchey
added a commit
to Walavouchey/osu-wiki
that referenced
this pull request
Jun 13, 2024
required after osu-wiki-tools 2.3.0, since Walavouchey/osu-wiki-tools#22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--base-commitnow defaults tomasterand behaves as a true base commit, not one-commit-after-the-base-commit--outdated-sincenow defaults to first commit diverging frommaster(i.e. the old--base-commitdefault)this allows flexibility to cover the case I mentioned on Discord, and the defaults should cover every normal case of working on a PR, as well as CI and
run_checksmaybe test that the default options do what they say they should do would be good? idk if necessary