Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use master instead of HEAD for --base-commit in outdated article check #11570

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

Walavouchey
Copy link
Member

@Walavouchey Walavouchey commented Jun 13, 2024

fixes issue reported on discord https://discord.com/channels/188630481301012481/218677502141399041/1250894073951289446

turns out i forgot what clayton said in Walavouchey/osu-wiki-tools#22 (comment) when updating in #11438

required after osu-wiki-tools 2.3.0, since
Walavouchey/osu-wiki-tools#22
@Walavouchey Walavouchey changed the title Change master instead of HEAD for --base-commit in outdated article check Use master instead of HEAD for --base-commit in outdated article check Jun 13, 2024
@github-actions github-actions bot added the area:meta non-article files label Jun 13, 2024
@Walavouchey Walavouchey changed the title Use master instead of HEAD for --base-commit in outdated article check Use master instead of HEAD for --base-commit in outdated article check Jun 13, 2024
@cl8n cl8n self-requested a review June 13, 2024 20:14
@cl8n
Copy link
Member

cl8n commented Jun 13, 2024

^just that should be okay, it's the same as the defaults now.

@TicClick TicClick enabled auto-merge June 13, 2024 20:53
@TicClick TicClick merged commit 3533d47 into ppy:master Jun 13, 2024
2 checks passed
@Walavouchey Walavouchey deleted the fix-ci branch June 13, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:meta non-article files size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants