Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase debugability for tristates #690

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Sep 21, 2023

This is not a necessary change, only convenient.

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.05%. Comparing base (733711f) to head (6436093).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #690      +/-   ##
==========================================
+ Coverage   79.01%   79.05%   +0.04%     
==========================================
  Files          74       74              
  Lines        3627     3634       +7     
==========================================
+ Hits         2866     2873       +7     
  Misses        761      761              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 21, 2023

Test results

       7 files     511 suites   19m 45s ⏱️
   408 tests    407 ✔️ 1 💤 0
2 856 runs  2 849 ✔️ 7 💤 0

Results for commit 6436093.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this improvement! Only one little addition to one tests to make it clearer how the result should look.

tests/notificationprofile/test_models.py Show resolved Hide resolved
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look very good from a debuggability perspective, but some of the changes deserve further clarification through naming and/or annotations.

src/argus/notificationprofile/models.py Outdated Show resolved Hide resolved
src/argus/notificationprofile/models.py Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hmpf hmpf force-pushed the log-tristates branch 2 times, most recently from 7aaf428 to e7656c3 Compare February 12, 2024 13:32
@hmpf hmpf requested a review from johannaengland February 12, 2024 13:58
tests/notificationprofile/test_models.py Outdated Show resolved Hide resolved
tests/notificationprofile/test_models.py Outdated Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Issues
16 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hmpf hmpf force-pushed the log-tristates branch 5 times, most recently from bb4bf95 to 6436093 Compare April 16, 2024 08:17
@hmpf hmpf mentioned this pull request Apr 16, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
15 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hmpf hmpf merged commit 615b760 into Uninett:master Apr 17, 2024
9 checks passed
@hmpf hmpf deleted the log-tristates branch April 17, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants