-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase debugability for tristates #690
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #690 +/- ##
==========================================
+ Coverage 79.01% 79.05% +0.04%
==========================================
Files 74 74
Lines 3627 3634 +7
==========================================
+ Hits 2866 2873 +7
Misses 761 761 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this improvement! Only one little addition to one tests to make it clearer how the result should look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look very good from a debuggability perspective, but some of the changes deserve further clarification through naming and/or annotations.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
7aaf428
to
e7656c3
Compare
Quality Gate passedIssues Measures |
bb4bf95
to
6436093
Compare
Quality Gate passedIssues Measures |
This is not a necessary change, only convenient.