Debug notification sending

[hmpf]

Merge after #690, might need to be adapted.

[github-actions]

Test results

       7 files     511 suites   19m 37s ⏱️
   409 tests    408 ✔️ 1 💤 0 ❌
2 863 runs  2 856 ✔️ 7 💤 0 ❌

Results for commit 582e82c.

♻️ This comment has been updated with latest results.

[johannaengland]

I also really would like some more tests for the send method to also document that way when we expect it to return False and when to return True.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 56.75676% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 78.78%. Comparing base (cce5eed) to head (582e82c).
Report is 1 commits behind head on master.

Files	Patch %	Lines
src/argus/notificationprofile/media/email.py	53.33%	7 Missing ⚠️
...rc/argus/notificationprofile/media/sms_as_email.py	22.22%	7 Missing ⚠️
src/argus/notificationprofile/media/__init__.py	0.00%	1 Missing ⚠️
src/argus/notificationprofile/media/base.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #760      +/-   ##
==========================================
- Coverage   79.00%   78.78%   -0.23%     
==========================================
  Files          74       74              
  Lines        3635     3653      +18     
==========================================
+ Hits         2872     2878       +6     
- Misses        763      775      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[johannaengland]

And I would like a changelog entry, because now we're actually changing the way that notifications are sent (since we break in sms if we encounter an error)

[hmpf]

This'll actually take multiple changelogs, which means this should have been multiple PRs.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud