Improve incidents file-path naming and template locations

[hmpf]

This is, and should be, a pure refactor.

This changes incident*s* to incident in directory names and moves a subset of templates in the templates/htmx/incident/ directory so that the structure is easier to understand.

Reading commit by commit is probably best.

Do come with suggestions for other renames/moves in the templates/htmx/incident/ directory.

[podliashanyk]

Import paths have to be fixed in following files:

• src/argus/htmx/urls.py
• src/argus/htmx/themes/views.py
• src/argus/htmx/dateformat/views.py
• src/argus/htmx/user/views.py

Another updates necessary:

• ARGUS_HTMX_FILTER_FUNCTION = "argus.htmx.incident.filter.incident_list_filter" in src/argus/htmx/defaults.py

Should we also singularize some of the path names in src/argus/htmx/incident/urls.py?

[hmpf]

Import paths have to be fixed in following files:

Urk, you mean my grep-fu has failed me? Bah.

Should we also singularize some of the path names in src/argus/htmx/incident/urls.py?

Do you mean

    path("update/<str:action>/", views.incidents_update, name="incidents-update"),
    path("filter/", views.filter_form, name="incidents-filter"),           

to

    path("update/<str:action>/", views.incident_update, name="incident-update"),
    path("filter/", views.filter_form, name="incident-filter"),           

Sure.

[podliashanyk]

Urk, you mean my grep-fu has failed me? Bah.

Those were tricky ones 😄

Should we also singularize some of the path names in src/argus/htmx/incident/urls.py?

Do you mean

    path("update/<str:action>/", views.incidents_update, name="incidents-update"),
    path("filter/", views.filter_form, name="incidents-filter"),           

to

    path("update/<str:action>/", views.incident_update, name="incident-update"),
    path("filter/", views.filter_form, name="incident-filter"),           

Sure.

Yes!

[hmpf]

Remember to also move BadgeDropdownMultiSelect and htmx/incidents/widgets/incident_source_select.html out of incidents, they are generic.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.83%. Comparing base (5c3d87f) to head (96c9a41).
Report is 6 commits behind head on master.

Files with missing lines	Patch %	Lines
src/argus/htmx/incident/views.py	50.00%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1098   +/-   ##
=======================================
  Coverage   79.83%   79.83%           
=======================================
  Files         145      145           
  Lines        5267     5267           
=======================================
  Hits         4205     4205           
  Misses       1062     1062           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[podliashanyk]

See URL name that needs fixing below.
Also, should we now delete the src/argus/htmx/incidents directory?

[hmpf]

Also, should we now delete the src/argus/htmx/incidents directory?

Yes, git will not do it for us.

[sonarqubecloud]

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[podliashanyk]

Have gone through the code and checked the functionality via Ui and nothing seems to break