Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dropdown widget #1097

Merged
merged 6 commits into from
Dec 18, 2024
Merged

Improve dropdown widget #1097

merged 6 commits into from
Dec 18, 2024

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Dec 17, 2024

For #1096

@hmpf hmpf requested review from podliashanyk and a team December 17, 2024 13:03
@hmpf hmpf added the polish Nice to have label Dec 17, 2024
@hmpf hmpf self-assigned this Dec 17, 2024
@hmpf hmpf added frontend Affects frontend CSS labels Dec 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.48%. Comparing base (c259f98) to head (529b835).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/argus/htmx/widgets.py 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1097      +/-   ##
==========================================
- Coverage   80.04%   79.48%   -0.56%     
==========================================
  Files         143      144       +1     
  Lines        5206     5119      -87     
==========================================
- Hits         4167     4069      -98     
- Misses       1039     1050      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@podliashanyk podliashanyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 🧑‍🍳👌
See a minor comment below.

src/argus/htmx/incidents/filter.py Show resolved Hide resolved
@hmpf hmpf merged commit 5c3d87f into Uninett:master Dec 18, 2024
13 checks passed
@hmpf hmpf deleted the improve-dropdown-widget branch December 18, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS frontend Affects frontend polish Nice to have
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants