Remove unused variables

src/argus/dev/management/commands/create_source.py

@@ -17,4 +17,4 @@ def handle(self, *args, **options):
         source_type = options.get("source_type") or "argus"
         sst = SourceSystemTypeFactory(name=source_type)
         user = SourceUserFactory(username=source)
-        ss = SourceSystemFactory(name=source, type=sst, user=user)
+        SourceSystemFactory(name=source, type=sst, user=user)

src/argus/notificationprofile/media/email.py

@@ -45,7 +45,7 @@ def send_email_safely(function, additional_error=None, *args, **kwargs) -> int:
     try:
         result = function(*args, **kwargs)
         return result
-    except ConnectionRefusedError as e:
+    except ConnectionRefusedError:
         EMAIL_HOST = getattr(settings, "EMAIL_HOST", None)
         if not EMAIL_HOST:
             LOG.error("Notification: Email: EMAIL_HOST not set, cannot send")

tests/auth/test_models.py

@@ -20,7 +20,7 @@ def test_is_end_user(self):
 
     def test_is_source_system(self):
         user = SourceUserFactory()
-        ss = SourceSystemFactory(user=user)
+        SourceSystemFactory(user=user)
         self.assertTrue(user.is_source_system)
 
 
@@ -56,7 +56,7 @@ def test_is_not_dormant_if_source_of_incident(self):
         user = SourceUserFactory()
         source = SourceSystemFactory(user=user)
 
-        incident = StatelessIncidentFactory(source=source)
+        StatelessIncidentFactory(source=source)
         self.assertTrue(user.is_used())
 
     def test_is_not_dormant_if_actor_of_event(self):

tests/incident/test_filters.py

@@ -112,7 +112,7 @@ def test_ticket_false(self):
     def test_tags_single(self):
         user = SourceUserFactory()
         tag1 = TagFactory(key="testkey1", value="testvalue1")
-        tag2 = TagFactory(key="testkey2", value="testvalue2")
+        TagFactory(key="testkey2", value="testvalue2")
         incident5 = StatefulIncidentFactory(source=self.source1)
         for incident in (self.incident1, self.incident2, self.incident3):
             IncidentTagRelation.objects.get_or_create(tag=tag1, incident=incident, added_by=user)

tests/incident/test_incident_fields.py

@@ -113,31 +113,31 @@ class KeyValueFieldTest(TestCase):
     def test_key_value_must_not_be_empty(self):
         f = KeyValueField()
         with self.assertRaises(ValidationError):
-            result = f.clean("")
+            f.clean("")
 
     def test_key_value_must_not_be_just_equals(self):
         f = KeyValueField()
         with self.assertRaises(ValidationError):
-            result = f.clean("=")
+            f.clean("=")
 
     def test_key_value_must_contain_at_least_one_equals(self):
         f = KeyValueField()
         with self.assertRaises(ValidationError):
-            result = f.clean("boo")
+            f.clean("boo")
 
     def test_value_cannot_be_empty(self):
         f = KeyValueField()
         with self.assertRaises(ValidationError):
-            result = f.clean("a=")
+            f.clean("a=")
 
     def test_key_must_fit_regex(self):
         # [a-z0-9_]+
         f = KeyValueField()
         with self.assertRaises(ValidationError):
-            result = f.clean("=v")
+            f.clean("=v")
         with self.assertRaises(ValidationError):
-            result = f.clean(" =v")
+            f.clean(" =v")
         with self.assertRaises(ValidationError):
-            result = f.clean("A=v")
+            f.clean("A=v")
         with self.assertRaises(ValidationError):
-            result = f.clean("-=v")
+            f.clean("-=v")

tests/incident/test_views.py

@@ -368,7 +368,7 @@ def test_source_cannot_delete_unowned_incident_if_indelible_is_False(self):
 
         source_type = SourceSystemTypeFactory()
         user = SourceUserFactory()
-        source = SourceSystemFactory(type=source_type, user=user)
+        SourceSystemFactory(type=source_type, user=user)
         self.client.force_authenticate(user=user)
 
         response = self.client.delete(path=f"/api/v2/incidents/{incident_pk}/")

tests/notificationprofile/test_github236.py

@@ -51,7 +51,6 @@ def tearDown(self):
         connect_signals()
 
     def test_sending_event_to_multiple_profiles_of_the_same_user_should_not_raise_exception(self):
-        LOG_PREFIX = "INFO:argus.notificationprofile.media:"
         # Send a test event
         self.incident = create_fake_incident()
         event = self.incident.events.get(type=Event.Type.INCIDENT_START)

tests/notificationprofile/test_serializers.py

@@ -91,7 +91,7 @@ def test_cannot_create_timeslot_with_duplicate_name(self):
         )
         # serializer.create works on already validated data
         with self.assertRaises(IntegrityError):
-            obj = serializer.create(validated_data)
+            serializer.create(validated_data)
 
     def test_can_update_timeslot(self):
         timeslot = TimeslotFactory(name="existing name", user=self.user)
@@ -127,4 +127,4 @@ def test_cannot_update_timeslot_with_duplicate_name(self):
         )
         # serializer.create works on already validated data
         with self.assertRaises(IntegrityError):
-            obj = serializer.update(timeslot, validated_data)
+            serializer.update(timeslot, validated_data)

tests/notificationprofile/test_views.py

@@ -233,7 +233,7 @@ def setUp(self):
         self.source2 = SourceSystemFactory(name="System 2", type=source_type2, user=source2_user)
 
         self.incident1 = StatelessIncidentFactory(source=self.source1)
-        incident2 = StatelessIncidentFactory(source=self.source2)
+        StatelessIncidentFactory(source=self.source2)
 
         timeslot1 = TimeslotFactory(user=user1, name="Never")
         filter1 = FilterFactory(