Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused variables #1010

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Remove unused variables #1010

merged 2 commits into from
Dec 9, 2024

Conversation

johannaengland
Copy link
Contributor

In preparation of adding F8 to ruff

@johannaengland johannaengland self-assigned this Nov 28, 2024
@johannaengland johannaengland mentioned this pull request Nov 28, 2024
Merged
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.44%. Comparing base (c83f348) to head (af85eda).

Files with missing lines Patch % Lines
src/argus/notificationprofile/media/email.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1010   +/-   ##
=======================================
  Coverage   82.44%   82.44%           
=======================================
  Files         132      132           
  Lines        4866     4866           
=======================================
  Hits         4012     4012           
  Misses        854      854

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hmpf
hmpf requested changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@hmpf hmpf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked by #1032, there's an error in test_when_context_processor_setting_is_unset_it_should_do_nothing, it should use raw_setting.

@hmpf hmpf added the blocked Another thing/issue has to be resolved before tackling this label Dec 3, 2024
@johannaengland johannaengland force-pushed the cleanup/remove-unused-variables branch from 3244bab to 5c5802f Compare December 4, 2024 12:51
@johannaengland johannaengland removed the blocked Another thing/issue has to be resolved before tackling this label Dec 4, 2024
@johannaengland
Copy link
Contributor Author

Blocked by #1032, there's an error in test_when_context_processor_setting_is_unset_it_should_do_nothing, it should use raw_setting.

I have added that part back in

@johannaengland johannaengland requested a review from hmpf December 4, 2024 12:51
@johannaengland johannaengland force-pushed the cleanup/remove-unused-variables branch from 5c5802f to 419d360 Compare December 4, 2024 12:51
@johannaengland johannaengland force-pushed the cleanup/remove-unused-variables branch from 419d360 to af85eda Compare December 4, 2024 12:55
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@johannaengland johannaengland merged commit 454cd88 into Uninett:master Dec 9, 2024
13 of 14 checks passed
@johannaengland johannaengland deleted the cleanup/remove-unused-variables branch December 9, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmpf hmpf hmpf approved these changes

@lunkwill42 lunkwill42 Awaiting requested review from lunkwill42

@stveit stveit Awaiting requested review from stveit

Assignees

@johannaengland johannaengland

Labels
lint/reformat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johannaengland @codecov-commenter @hmpf