Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SuggestionPlugin support Composition event #1295

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ClytzeL
Copy link

@ClytzeL ClytzeL commented Dec 2, 2024

fix #1283
/claim #1283

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Dec 3, 2024 6:12am

Copy link

vercel bot commented Dec 2, 2024

Someone is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

algora-pbc bot commented Dec 2, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

@YousefED
Copy link
Collaborator

YousefED commented Dec 3, 2024

  • Can you explain why there was a different PR necessary?
  • Why do we need to listen to domevents manually, can't we check view.composing like here? ueberdosis/tiptap@9789372

@ClytzeL
Copy link
Author

ClytzeL commented Dec 4, 2024

  • Can you explain why there was a different PR necessary?
  • Why do we need to listen to domevents manually, can't we check view.composing like here? ueberdosis/tiptap@9789372

@YousefED
1.A different PR here because #1292 can not match my requirement. And I had changed source code in my project.I wish these changes can commit to the upstream blocknote.
2.I am not familiar with tiptap and before coding I had missed the information.I will try this.Thans for your advice.

@YousefED
Copy link
Collaborator

YousefED commented Dec 9, 2024

1.A different PR here because #1292 can not match my requirement. And I had changed source code in my project.I wish these changes can commit to the upstream blocknote.

Can you explain why on that PR? (I mean, can you a comment on that PR why there is an issue?)

@ClytzeL
Copy link
Author

ClytzeL commented Dec 9, 2024

1.A different PR here because #1292 can not match my requirement. And I had changed source code in my project.I wish these changes can commit to the upstream blocknote.

Can you explain why on that PR? (I mean, can you a comment on that PR why there is an issue?)

@YousefED You would like me to comment on #1292 ?

@YousefED
Copy link
Collaborator

YousefED commented Dec 9, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request suggestion menu mentions to support CompositionEvent for chinese input
2 participants