-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
request suggestion menu mentions to support CompositionEvent for chinese input #1283
Comments
Thanks for the report. The change would probably need to be made in this file: https://github.com/TypeCellOS/BlockNote/blob/main/packages/core/src/extensions/SuggestionMenu/SuggestionPlugin.ts This (from a different project) might be a helpful pointer: ueberdosis/tiptap@9789372 /bounty 10 |
💎 $10 bounty • BlockNoteSteps to solve:
Thank you for contributing to TypeCellOS/BlockNote! Add a bounty • Share on socials
|
@YousefED can you please assign this one ? Let me have a look |
/attempt #1283 Options |
@ClytzeL can you see if this fixes it? #1292 (comment) |
@YousefED @mehul-m-prajapati Thanks for support.There is still a little problem.I had already comment in the commit.Thanks again! By the way,I would like to ask how to debug the @blocknote/core package in my project. Since the @blocknote/react package internally depends on a fixed version of @blocknote/core, I cannot change the version of @blocknote/core by only modifying it. My project uses Turbo + pnpm. Thank you for your help. |
@ClytzeL : I have updated the code as per the review comment. Please test again and let me know if it works now. |
@mehul-m-prajapati Thanks for support.Would you show me how to test this #1292 before npm publish? |
I don't know how to test it before |
@mehul-m-prajapati Wlould you test on this preview link:https://blocknote-git-fork-mehul-m-prajapati-compositio-59cce9-typecell.vercel.app/custom-schema/suggestion-menus-mentions Maybe this commit has regression.When I input @st,I can not filter steve in the list.Thanks for support. |
💡 @ClytzeL submitted a pull request that claims the bounty. You can visit your bounty board to reward. |
#1295 I have tested this in my project.fix safari selection change case suggestion close when in composition event. |
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Will you could support suggestion menu mentions with chinese search,ref: https://developer.mozilla.org/zh-CN/docs/Web/API/CompositionEvent
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Bonus
[ ] I'm a sponsor and would appreciate if you could look into this sooner than later 💖
The text was updated successfully, but these errors were encountered: