Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request suggestion menu mentions to support CompositionEvent for chinese input #1283

Open
ClytzeL opened this issue Nov 28, 2024 · 12 comments · May be fixed by #1295
Open

request suggestion menu mentions to support CompositionEvent for chinese input #1283

ClytzeL opened this issue Nov 28, 2024 · 12 comments · May be fixed by #1295
Labels
💎 Bounty enhancement New feature or request

Comments

@ClytzeL
Copy link

ClytzeL commented Nov 28, 2024

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Will you could support suggestion menu mentions with chinese search,ref: https://developer.mozilla.org/zh-CN/docs/Web/API/CompositionEvent

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Bonus
[ ] I'm a sponsor and would appreciate if you could look into this sooner than later 💖

@ClytzeL ClytzeL added the enhancement New feature or request label Nov 28, 2024
@YousefED
Copy link
Collaborator

Thanks for the report. The change would probably need to be made in this file: https://github.com/TypeCellOS/BlockNote/blob/main/packages/core/src/extensions/SuggestionMenu/SuggestionPlugin.ts

This (from a different project) might be a helpful pointer: ueberdosis/tiptap@9789372

/bounty 10

Copy link

algora-pbc bot commented Nov 28, 2024

💎 $10 bounty • BlockNote

Steps to solve:

  1. Start working: Comment /attempt #1283 with your implementation plan
  2. Submit work: Create a pull request including /claim #1283 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to TypeCellOS/BlockNote!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🔴 @Anshgrover23 Nov 28, 2024, 9:49:12 AM WIP
🟢 @mehul-m-prajapati Nov 29, 2024, 8:16:29 PM #1292
🟢 @ClytzeL #1295

@hunxjunedo
Copy link
Contributor

@YousefED can you please assign this one ? Let me have a look

@mehul-m-prajapati
Copy link

mehul-m-prajapati commented Nov 29, 2024

/attempt #1283

@YousefED
Copy link
Collaborator

@ClytzeL can you see if this fixes it? #1292 (comment)

@ClytzeL
Copy link
Author

ClytzeL commented Dec 2, 2024

@ClytzeL can you see if this fixes it? #1292 (comment)

@YousefED @mehul-m-prajapati Thanks for support.There is still a little problem.I had already comment in the commit.Thanks again!

By the way,I would like to ask how to debug the @blocknote/core package in my project. Since the @blocknote/react package internally depends on a fixed version of @blocknote/core, I cannot change the version of @blocknote/core by only modifying it. My project uses Turbo + pnpm. Thank you for your help.

@mehul-m-prajapati
Copy link

@ClytzeL : I have updated the code as per the review comment. Please test again and let me know if it works now.

@ClytzeL
Copy link
Author

ClytzeL commented Dec 2, 2024

@ClytzeL : I have updated the code as per the review comment. Please test again and let me know if it works now.

@mehul-m-prajapati Thanks for support.Would you show me how to test this #1292 before npm publish?

@mehul-m-prajapati
Copy link

@ClytzeL : I have updated the code as per the review comment. Please test again and let me know if it works now.

@mehul-m-prajapati Thanks for support.Would you show me how to test this #1292 before npm publish?

I don't know how to test it before npm publish. @YousefED : Can you please help on this?

@ClytzeL
Copy link
Author

ClytzeL commented Dec 2, 2024

@mehul-m-prajapati Wlould you test on this preview link:https://blocknote-git-fork-mehul-m-prajapati-compositio-59cce9-typecell.vercel.app/custom-schema/suggestion-menus-mentions

Maybe this commit has regression.When I input @st,I can not filter steve in the list.Thanks for support.

@ClytzeL ClytzeL linked a pull request Dec 2, 2024 that will close this issue
Copy link

algora-pbc bot commented Dec 2, 2024

💡 @ClytzeL submitted a pull request that claims the bounty. You can visit your bounty board to reward.

@ClytzeL
Copy link
Author

ClytzeL commented Dec 2, 2024

#1295 I have tested this in my project.fix safari selection change case suggestion close when in composition event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 Bounty enhancement New feature or request
Projects
None yet
4 participants