Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Support publishing the kmp jvm artifacts to maven repos #130

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

cleanup: Rename the published project from 'lib' to 'tox4j-c'

765560e
Select commit
Loading
Failed to load commit list.
Draft

chore: Support publishing the kmp jvm artifacts to maven repos #130

cleanup: Rename the published project from 'lib' to 'tox4j-c'
765560e
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded Dec 29, 2024 in 1s

3 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : chore: Support publishing the kmp jvm artifacts to maven repos
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: COMMIT

  • ✔️ Your commit messages met the specified criteria
    Input : chore: gitignore Android Studio's local Gradle settings,chore: Set up the Maven Publish plugin

The last version we used to publish was 0.2.3, so I bumped the version
to 0.3.0 due to all the breaking changes that were made when porting
everything from Scala to Kotlin.,cleanup: Rename the published project from 'lib' to 'tox4j-c'

'tox4j' is already taken by the root project.
Settings : {"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : This is enough to be able to publish tox4j w/ gradlew publishToMavenLocal, and depend on org.toktok:tox4j-c:0.3.0 from a different project and get errors like
aTox/domain/src/main/kotlin/tox/ToxAvEventListener.kt:74:5 'callState' overrides nothing. Potential signatures for overriding:
fun callState(friendNumber: ToxFriendNumber, callState: Set<ToxavFriendCallState>, state: Unit): Unit
aTox/domain/src/main/kotlin/tox/ToxUtil.kt:33:5 Argument type mismatch: actual type is 'kotlin.Int', but 'kotlin.UShort' was expected.
aTox/domain/src/main/kotlin/tox/ToxWrapper.kt:116:13 Argument type mismatch: actual type is 'kotlin.Pair<A, B>', but 'kotlin.Pair<ltd.evilcorp.domain.tox.PublicKey, kotlin.Int>' was expected.

Note that this does nothing with the .so-dependencies, so depending on jvm-toxcore-c like this right now will require the user to also place libtox4j-c.so in the jniLibs-structure themselves.


This change is Reviewable

Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}