Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Support publishing the kmp jvm artifacts to maven repos #130

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

chore: Support publishing the kmp jvm artifacts to maven repos #130

wants to merge 3 commits into from

Conversation

robinlinden
Copy link
Member

@robinlinden robinlinden commented Dec 29, 2024 •
edited
Loading

This is enough to be able to publish tox4j w/ gradlew publishToMavenLocal, and depend on org.toktok:tox4j-c:0.3.0 from a different project and get errors like

aTox/domain/src/main/kotlin/tox/ToxAvEventListener.kt:74:5 'callState' overrides nothing. Potential signatures for overriding:
fun callState(friendNumber: ToxFriendNumber, callState: Set<ToxavFriendCallState>, state: Unit): Unit
aTox/domain/src/main/kotlin/tox/ToxUtil.kt:33:5 Argument type mismatch: actual type is 'kotlin.Int', but 'kotlin.UShort' was expected.
aTox/domain/src/main/kotlin/tox/ToxWrapper.kt:116:13 Argument type mismatch: actual type is 'kotlin.Pair<A, B>', but 'kotlin.Pair<ltd.evilcorp.domain.tox.PublicKey, kotlin.Int>' was expected.

Note that this does nothing with the .so-dependencies, so depending on jvm-toxcore-c like this right now will require the user to also place libtox4j-c.so in the jniLibs-structure themselves.

This change is Reviewable

@robinlinden
chore: gitignore Android Studio's local Gradle settings
ddd27ff
@robinlinden
chore: Set up the Maven Publish plugin
9cfc50d 
The last version we used to publish was 0.2.3, so I bumped the version
to 0.3.0 due to all the breaking changes that were made when porting
everything from Scala to Kotlin.
@robinlinden
cleanup: Rename the published project from 'lib' to 'tox4j-c'
765560e 
'tox4j' is already taken by the root project.
@github-actions github-actions bot added the chore Updating grunt tasks etc; no production code change label Dec 29, 2024
@robinlinden robinlinden added this to the master milestone Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore Updating grunt tasks etc; no production code change
Projects
None yet
Milestone
master
Development

Successfully merging this pull request may close these issues.
1 participant
@robinlinden