Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update push descriptor workaround for upstream MoltenVK fix #139

Closed
wants to merge 1 commit into from
Closed

Update push descriptor workaround for upstream MoltenVK fix #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions vulkan/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,11 +855,13 @@ void Device::init_workarounds()
// Events are not supported in MoltenVK.
// TODO: Use VK_KHR_portability_subset to determine this.
workarounds.emulate_event_as_pipeline_barrier = true;
// MoltenVK is broken with push descriptor templates.
// KhronosGroup/MoltenVK issue 2323.
workarounds.broken_push_descriptors = true;
LOGW("Emulating events as pipeline barriers on Metal emulation.\n");
LOGW("Disabling push descriptors on Metal emulation.\n");
if (gpu_props.driverVersion < VK_MAKE_VERSION(1, 2, 11)) {
// MoltenVK was broken with push descriptor templates.
// KhronosGroup/MoltenVK issue 2323, fix observed in driver version 1.2.11.
workarounds.broken_push_descriptors = true;
LOGW("Emulating events as pipeline barriers on Metal emulation.\n");
LOGW("Disabling push descriptors on Metal emulation.\n");
}
#else
bool sync2_workarounds = false;
const bool mesa_driver = ext.driver_id == VK_DRIVER_ID_MESA_RADV ||
Expand Down
Loading