Update push descriptor workaround for upstream MoltenVK fix #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The perf of the implementation is still deeply questionable (malloc every push), so I'll keep the workaround as-is. |
|
Would you be able to make a comment on their linked fix PR (or original issue) to that effect? Given that the issue was closed, they may be under the impression that it's fine, even though there are still concerns. It seems like they modified the implementation to allocate less often, but I'm not in a position to make a well-informed comment on the problem myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested and confirmed that push descriptors work in paraLLEl-RDP on the latest master of MoltenVK following KhronosGroup/MoltenVK#2327. Fix will be shipped in the forthcoming driver version 1.2.11.