Update form confirmation email and show requested tour info #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
approved these changes
Sep 16, 2024
| @@ -44,18 +44,26 @@ def submit_ticket(form_data): | |||
|
|
|||
|
|
|||
| def send_confirmation_email(form_name, form_data): | |||
|
|
|||
| tour_receipt = "" | |||
| if form_name == "Tour Request Form": | |||
There was a problem hiding this comment.
Musing. I thought, "Should we use a different, less volatile, identifier". But form ID is less intuitive, and name is unlikely to change. It might even be more likely that the form is accidentally deleted and recreated… Coupling this logic to form name means such a problem case could be fixed by admin.
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Related
Changes
Testing