Feat/tup 700 core components node pkg use pkg fixes #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* task/wg-76-project-listing-query * Address linting errors * - Combines DesignSafe and Hazmapper project get requests into one hook * - Linting
* Simplify imports in react app * Fix linting * Revert changes to core-wrappers * Add maping to jest * Fix linting * Fix pretty issues * Remove unused imports from mistake in conflict resolution
nathanfranklin
commented
Oct 18, 2024
nathanfranklin
merged commit 65b1838
into
feat/TUP-700-core-components-node-pkg--use-pkg
5 checks passed
nathanfranklin
deleted the
feat/TUP-700-core-components-node-pkg--use-pkg--fixes
branch
nathanfranklin
added a commit
that referenced
this pull request
Oct 21, 2024
* feat: tup-700 replace core-components + /wrappers * fix: FieldWrapperFormik not found Problem was forgetting to build core-components before packing. * fix: FieldWrapper… fields crashed form Problem was… core-components not coded/tested for external usage. Fixes in TACC/tup-ui: TACC/tup-ui@cb73d54 TACC/tup-ui@836f372 * chore: save latest core-components hash * Feat/tup 700 core components node pkg use pkg fixes (#272) * Update config files * task/wg-76-project-listing-query (#265) * task/wg-76-project-listing-query * Address linting errors * - Combines DesignSafe and Hazmapper project get requests into one hook * - Linting * Add local version of QueryNavItem to illustrate issue * Use @tacc/core-components version 0.0.3-beta.0 * Fix prettier issues * Update package lock * Update package-lock.json again * hotfix: simplify imports in react app (#260) * Simplify imports in react app * Fix linting * Revert changes to core-wrappers * Add maping to jest * Fix linting * Fix pretty issues * Remove unused imports from mistake in conflict resolution * Update as core-components is now installed from package --------- Co-authored-by: sophia-massie <[email protected]> * Bump package-lock.json * Remove local QueryNavItem --------- Co-authored-by: Nathan Franklin <[email protected]> Co-authored-by: sophia-massie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This PR makes a few changes to #264. It works along side TACC/tup-ui#484
PR Status:
Related Jira tickets:
Summary of Changes:
Testing Steps:
rm -rf node_modulesand thennpm installGeoapiBackendEnvironment.Dev) or staging backend (GeoapiBackendEnvironment.Staging) in react/src/secret_local.tsnpm run devNotes:
[cause]: Error: Cannot find module '@rollup/rollup-linux-x64-gnu'