feat: TUP-700 @tacc/core-components - use, test, fix

[wesleyboar]

Overview

1. Test …/core-components as @tacc/core-components in clients.
2. Fix issues.

Related

• TUP-700
• fixes bugs in feat: TUP-700 @tacc/core-components #463
• required by feat: tup-700 @tacc/core-components node pkg TACC-Cloud/hazmapper#239
• requires Move to peer dependencies #484

Changes

• fixed dependency organization
• refactored Formik field wrappers to work from external package

Testing

0. ✅ Package @tacc/core-components

0. npm install --include=optional --workspace=libs/core-components

1. Build @tacc/core-components i.e.
   npx nx build core-components

2. Package @tacc/core-components (for use in local install) e.g.
   npm pack --workspace=libs/core-components --pack-destination=../¹

3. Prepare a client to use @tacc/core-components package.

   See sections 1.A.–1.C. for status

   0. Create or Checkout branch feat/TUP-700-core-components-node-pkg--use-pkg.
   1. Delete react/src/core-components and react/src/core-wrappers.
   2. Find code references to core-components and core-wrappers.
   3. Replace imports of core-components and core-wrappers with @tacc/core-components.
   4. Remove non-import references to core-components and core-wrappers.

1.A. ✅ & ➡️ Client: TACC-Cloud/Hazmapper

Started: TACC-Cloud/hazmapper#239

1. Set up https://github.com/TACC-Cloud/hazmapper.
2. Verify app renders with its core-components.
3. Checkout feat/TUP-700-core-components-node-pkg--use-pkg.
4. npm install --save ../../tacc-core-components-0.0.1.tgz¹
5. Verify no errors.
6. Verify app works with installed core-components.
   Feat/tup 700 core components node pkg use pkg fixes TACC-Cloud/hazmapper#272

1.B. ⏯️ Client: TACC/Core-Portal

Skipped. ²

1. ➡️ Set up https://github.com/TACC/Core-Portal.
2. Verify app renders with its core-components.
3. Checkout feat/TUP-700-core-components-node-pkg--use-pkg.
4. npm install --save ../../tacc-core-components-0.0.1.tgz¹
5. Verify no errors.
6. Verify app works with installed core-components.

1.C. ✅ Client: TACC/tup-ui

Skipped. ²

1. ➡️ Set up 2nd clone of https://github.com/TACC/tup-ui.
2. Verify app renders with its core-components.
3. Checkout feat/TUP-700-core-components-node-pkg--use-pkg.
4. npm install --save ../../tacc-core-components-0.0.1.tgz¹
5. Verify no errors.
6. Verify app works with installed core-components.

UI

Skipped.

Notes

Archived

[!WARNING]
Installing on client TACC-Cloud/Hazmapper causes warnings about Vite version because client's Vite version v3.0.7 is too old to be used as a peer dependency by a dev dependency of an optional dependency of @tacc/core-components.

Footnotes

1. Tester should check paths to @tacc/core-components: to where to package, from where to install. ↩ ↩² ↩³ ↩⁴

2. Having this library work on TUP client as internal library and on Hazmapper client is enough for now. I'd like to get this PR merged because it is working on two clients and merging it allows us to move core-components to its own repo. ↩ ↩²