[Payment] fix cancel payment #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oallain
force-pushed
the
fix/cancel-payment
branch
from
7ae357d
to
b7eedea
Compare
|
Hello @Zales0123 @SirDomin and others ;) I fixed the bug that made two new payments (one in Regards |
Jibbarth
approved these changes
May 5, 2023
oallain
force-pushed
the
fix/cancel-payment
branch
3 times, most recently
from
26ba07b
to
a753f4b
Compare
|
Hello, This bug is still present, so I've rebased my branch to make it compatible with the new version. Can you take a look? Ping @GSadee |
Zales0123
approved these changes
Sep 9, 2023
oallain
force-pushed
the
fix/cancel-payment
branch
from
a753f4b
to
c17b516
Compare
NoResponseMate
approved these changes
Jan 18, 2024
NoResponseMate
force-pushed
the
fix/cancel-payment
branch
from
c17b516
to
e068f7c
Compare
GSadee
approved these changes
Jan 18, 2024
|
Thank you, Olivier! 🥇 |
GSadee
added a commit
that referenced
this pull request
Apr 8, 2024
…seMate, oallain, GSadee, mpysiak) This PR was merged into the 1.5-dev branch. Discussion ---------- - **Fix 1.13** - **Update composer.json, add ecs check** - **Limit builds** - **Add support for node 20** - **Add state machine config, add migrations for postgresql** | Q | A | --------------- | ----- | Branch? | 1.5 | Bug fix? | no | New feature? | no | Related tickets | Commits ------- 6076771 [Composer] Remove Psalm 12ecb57 [Psalm] Remove configuration file 2e5bff9 [Psalm] Remove outdated annotations 8f63d74 minor #283 Bye Psalm 👋 (Rafikooo) e068f7c fix cancel payment 65c1dca bug #273 [Payment] fix cancel payment (oallain) 7347d95 [Conflict] Add conflict with behat/mink-selenium2-driver:>=1.7.0 bea2505 [CI] Bump version of symfony/flex to ^2.4 9ab11fd bug #285 Conflict `behat/mink-selenium2-driver:>=1.7.0` && Bump version of `symfony/flex` to `^2.4` (Rafikooo) a8265ab Fix 1.13 b80121a Update composer.json, add ecs check b538220 Limit builds 7e3a348 Add support for node 20 63566c1 Add state machine config, add migrations for postgresql 9eadb53 Remove conflict 5296209 Change build 1627d0b Fixes after code review e905c9f Fix Spec 793091f Merge branch 'master' into fix/1.13 0065fc5 Fixes after testing 'Enable' method eebcada Fix BC changes d03ea1d Merge remote-tracking branch 'leszczuu/fix/1.13' into fix/1.13 47f7eaa Fix BC changes fed5c61 Remove old services 563fdd2 Fixes after CR 773bc07 Fixes b183882 More fixes after CR 816a068 Fixes after code review 553b05a Add specs 68f8f73 Fix phpstan fb93f1d Fix ecs d1ba389 Fix readme Sylius logo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the order already has a payment in the "new" status, then the Sylius orderPaymentProcessor must not be processed, otherwise a new payment in the "cart" status will be created, which will cause errors (2 payments in order ...).
Before :
After :
