Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Payment] remove payment processing when canceling payment #249

Open
wants to merge 1 commit into
base: 1.4
Choose a base branch
from
Open

[Payment] remove payment processing when canceling payment #249

wants to merge 1 commit into from

Conversation

SirDomin
Copy link
Contributor

@SirDomin SirDomin commented Jun 1, 2022

Q A
Branch? 1.4
Bug fix? yes
New feature? no
Related tickets

@SirDomin SirDomin added the Bug label Jun 1, 2022
@oallain oallain mentioned this pull request Jan 27, 2023
Merged
oallain
oallain requested changes Sep 23, 2023
View reviewed changes
Copy link
Member

@oallain oallain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced by #273

GSadee added a commit that referenced this pull request Jan 18, 2024
@GSadee
bug #273 [Payment] fix cancel payment (oallain)
65c1dca 
This PR was merged into the 1.5 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.5
| Bug fix?        | yes
| New feature?    | no
| Related tickets | replace #249

If the order already has a payment in the "new" status, then the Sylius orderPaymentProcessor must not be processed, otherwise a new payment in the "cart" status will be created, which will cause errors (2 payments in order ...).

Before : 
![image](https://user-images.githubusercontent.com/6593252/215053880-97319618-b24e-4a10-8281-15b71d494912.png)

After :
![image](https://user-images.githubusercontent.com/6593252/215054517-63061d73-37d3-4644-b16c-f57867a7e7d0.png)


Commits
-------

e068f7c fix cancel payment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oallain oallain oallain requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SirDomin @oallain