Chat threads

src/chat/chatLogic.js

@@ -113,39 +113,57 @@ export class ChatChannel {
 
 // ////////// Utility functions
 
+// Have to not loop forever if fed loops
 export async function allVersions (message) {
   const versions = [message]
+  const done = {}
+  done[message.ur] = true
   let m = message
   while (true) { // earlier?
     const prev = store.any(null, ns.dct('isReplacedBy'), m, m.doc())
-    if (!prev) break
+    if (!prev || done[prev.uri]) break
     await store.fetcher.load(prev)
     versions.unshift(prev)
+    done[prev.uri] = true
     m = prev
   }
   m = message
   while (true) { // later?
     const next = store.any(m, ns.dct('isReplacedBy'), null, m.doc())
-    if (!next) break
+    if (!next || done[next.uri]) break
     versions.push(next)
+    done[next.uri] = true
     m = next
   }
   return versions
 }
 
 export async function originalVersion (message) {
   let msg = message
+  const done = {}
+  // done[message.ur] = true
   while (msg) {
+      if (done[msg.uri]) {
+          console.error('originalVersion: verion loop' + message)
+          return message
+      }
+      done[msg.uri] = true
     message = msg
     await store.fetcher.load(message)
-    msg = store.any(null, ns.dct('isReplacedBy'), message, message.doc()) // @@@ may need to load doc
+    msg = store.any(null, ns.dct('isReplacedBy'), message, message.doc())
   }
   return message
 }
 
 export async function mostRecentVersion (message) {
   let msg = message
+  const done = {}
   while (msg) {
+      if (done[msg.uri]) {
+          console.error('mostRecentVersion: verion loop' + message)
+          return message
+      }
+    done[msg.uri] = true
     message = msg
     await store.fetcher.load(message)
     msg = store.any(message, ns.dct('isReplacedBy'), null, message.doc())

src/chat/infinite.js

@@ -13,7 +13,7 @@ import * as ns from '../ns'
 import * as widgets from '../widgets'
 // import * as pad from '../pad'
 // import { DateFolder } from './dateFolder'
-import { ChatChannel, isDeleted, mostRecentVersion } from './chatLogic'
+import { ChatChannel, isDeleted, isReplaced, mostRecentVersion } from './chatLogic'
 import { renderMessageEditor, renderMessageRow } from './message'
 
 // const UI = { authn, icons, ns, media, pad, $rdf, store, style, utils, widgets }
@@ -141,11 +141,14 @@ export async function infiniteMessageArea (dom, wasStore, chatChannel, options)
 
   // Called once per original message displayed
   async function addMessage (message, messageTable) {
-    const latest = await mostRecentVersion(message)
+    // const latest = await mostRecentVersion(message)
     // const content = store.any(latest, ns.sioc('content'))
-    if (isDeleted(latest) && !options.showDeletedMessages) {
+    if (isDeleted(message) && !options.showDeletedMessages) {
       return // ignore deleted messaged -- @@ could also leave a placeholder
     }
+    if (isReplaced(message)) { //
+        return // this is old version
+    }
     let thread = store.any(null, ns.sioc('has_member'), message, message.doc())
     const id = store.any(message, ns.sioc('id'), null, message.doc())
     if (id && !thread) {
@@ -602,7 +605,9 @@ export async function infiniteMessageArea (dom, wasStore, chatChannel, options)
 
   async function loadInitialContent () {
     function yank () {
-      selectedMessageTable.selectedElement.scrollIntoView({ block: 'center' })
+        if (selectedMessageTable && selectedMessageTable.selectedElement) {
+            selectedMessageTable.selectedElement.scrollIntoView({ block: 'center' })
+        }
     }
 
     // During initial load ONLY keep scroll to selected thing or bottom

src/preferences.js

@@ -41,6 +41,10 @@ export function recordSharedPreferences (subject, context) {
   return new Promise(function (resolve, reject) {
     const sharedPreferences = kb.any(subject, ns.ui('sharedPreferences'))
     if (!sharedPreferences) {
+      if (!kb.updater.editable(subject.doc())) {
+          console.log(` Cant make shared preferences, may not change ${subject.doc}`)
+          resolve(context)
+      }
       const sp = $rdf.sym(subject.doc().uri + '#SharedPreferences')
       const ins = [
         $rdf.st(subject, ns.ui('sharedPreferences'), sp, subject.doc())