Chat threads #531
Open
Chat threads #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallTed
suggested changes
Mar 14, 2023
TallTed
reviewed
Apr 5, 2023
src/preferences.js
Outdated
| @@ -41,6 +41,10 @@ export function recordSharedPreferences (subject, context) { | |||
| return new Promise(function (resolve, reject) { | |||
| const sharedPreferences = kb.any(subject, ns.ui('sharedPreferences')) | |||
| if (!sharedPreferences) { | |||
| if (!kb.updater.editable(subject.doc())) { | |||
| console.log(` Cant make shared preferences, may not change ${subject.doc}`) | |||
There was a problem hiding this comment.
Suggested change
| console.log(` Cant make shared preferences, may not change ${subject.doc}`) | |
| console.log(` Cannot make shared preferences; may not change ${subject.doc}`) |
TallTed
suggested changes
Apr 10, 2023
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add threads functionality, allowing "reply in thread", the display of thread at the right hand side, and display and add social actions (reactions) to messages.
This should be compatible with threads imported by https://github.com/solid-contrib/gitter-solid the bridge from matrix. it includes emoji-based reactions. (You can't create those on the solid side yet)