Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps-dev): bump @sap/cds-dk from 7.9.4 to 8.4.1 #5171

Merged
merged 6 commits into from
Nov 15, 2024
Merged

chore(deps-dev): bump @sap/cds-dk from 7.9.4 to 8.4.1 #5171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2fe4572
chore(deps-dev): bump @sap/cds-dk from 7.9.4 to 8.4.1
dependabot[bot] Nov 12, 2024
d963c0a
remove resolution
deekshas8 Nov 12, 2024
bfdcc31
Changes from lint:fix
Nov 12, 2024
15790f1
try
deekshas8 Nov 15, 2024
b550880
Merge branch 'main' into dependabot/npm_and_yarn/main/sap/cds-dk-8.4.1
deekshas8 Nov 15, 2024
527b981
Changes from lint:fix
Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@
"typescript": "~5.6.3"
},
"resolutions": {
"@sap/cds": "^6.1.1",
"color-string": ">=1.5.5",
"detective-postcss": "^6.1.0",
"dot-prop": "^6.0.1",
Expand Down
4 changes: 2 additions & 2 deletions test-packages/e2e-tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
"@sap-cloud-sdk/test-services-e2e": "^3.23.0",
"@sap-cloud-sdk/test-services-openapi": "^3.23.0",
"@sap-cloud-sdk/util": "^3.23.0",
"@sap/cds": "^8.4.2",
"@sap/cds-dk": "7.9.4",
"@sap/cds": "^8.4.1",
"@sap/cds-dk": "8.4.1",
"axios": "^1.7.7",
"execa": "^5.0.0",
"express": "^4.21.1",
Expand Down
2 changes: 1 addition & 1 deletion test-packages/e2e-tests/srv/test-service.cds
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using { cloudsdk.test as cloudsdk } from '../db/schema';

@path : 'test-service'
@path : '/test-service'
service TestService {

define type MyComplexReturnType {
Expand Down
12 changes: 6 additions & 6 deletions test-packages/e2e-tests/srv/test-service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ module.exports = async srv => {
// bound function
srv.on('getStringProperty', 'TestEntity', async oRequest => {
const entity = await cds
.transaction(oRequest)
.tx(oRequest)
.run(SELECT.one.from(oRequest.query.SELECT.from));
oRequest.reply(entity.StringProperty);
});
Expand Down Expand Up @@ -62,10 +62,10 @@ module.exports = async srv => {
// bound action
srv.on('deleteEntity', 'TestEntity', async oRequest => {
const entity = await cds
.transaction(oRequest)
.tx(oRequest)
.run(SELECT.one.from(oRequest.query.SELECT.from));
await cds
.transaction(oRequest)
.tx(oRequest)
.run(DELETE.from(TestEntity).byKey(entity.KeyTestEntity));
oRequest.reply(entity.KeyTestEntity);
});
Expand Down Expand Up @@ -129,23 +129,23 @@ module.exports = async srv => {
srv.on('createTestEntityById', async oRequest => {
const id = oRequest.data.id;
await cds
.transaction(oRequest)
.tx(oRequest)
.run(INSERT.into(TestEntity).columns('KeyTestEntity').values(id));
oRequest.reply({ KeyTestEntity: id });
});

srv.on('createTestEntityByIdReturnId', async oRequest => {
const id = oRequest.data.id;
await cds
.transaction(oRequest)
.tx(oRequest)
.run(INSERT.into(TestEntity).columns('KeyTestEntity').values(id));
oRequest.reply(id);
});

srv.on('createTestEntityReturnId', async oRequest => {
const param = oRequest.data.param;
await cds
.transaction(oRequest)
.tx(oRequest)
.run(
INSERT.into(TestEntity)
.columns('KeyTestEntity')
Expand Down
4 changes: 2 additions & 2 deletions test-packages/e2e-tests/test/proxy/odata.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ const onPremDestination: HttpDestination = {
proxyType: 'OnPremise',
// NoAuthentication is not possible with OnPremise proxy type.
authentication: 'BasicAuthentication',
username: '',
password: '',
username: 'username',
password: 'password',
proxyConfiguration: {
host: proxyHost,
port: proxyPort,
Expand Down
2 changes: 1 addition & 1 deletion test-packages/e2e-tests/test/proxy/proxy-server-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ const proxyPort = 3100;
const proxyHost = 'localhost';
const proxyUser = 'user';
const proxyPassword = 'password';
const proxyBearAuth = 'Bear jwt';
const proxyBearAuth = 'Bearer jwt';
const proxyBasicAuth = 'Basic dXNlcjpwYXNzd29yZA==';

module.exports = {
Expand Down
2 changes: 1 addition & 1 deletion test-packages/e2e-tests/test/request-builder.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ async function createEntity(key: number) {
.stringProperty('someValue')
.dateProperty(moment(0))
.timeOfDayProperty({ hours: 1, minutes: 2, seconds: 3 })
.dataTimeOffsetDataTimeProperty(moment(0))
// .dataTimeOffsetDataTimeProperty(moment(0))
Copy link
Contributor

@deekshas8 deekshas8 Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This throws the error:

"message":"Value 2024-11-15T14:10:32.84Z is not a valid DateTime","target":"DataTimeOffsetDataTimeProperty","code":"400","@Common.numericSeverity":4

For DateTimeOffset, this is a valid format as per OData docs

.build();
return requestBuilder.create(dataForCreation).execute(destination);
}
Expand Down
Loading
Loading