Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump @sap/cds-dk from 7.9.4 to 8.4.1 #5171

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 12, 2024

Bumps @sap/cds-dk from 7.9.4 to 8.4.1.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Nov 12, 2024
@deekshas8
Copy link
Contributor

@dependabot recreate

Bumps [@sap/cds-dk](https://cap.cloud.sap/) from 7.9.4 to 8.4.1.

---
updated-dependencies:
- dependency-name: "@sap/cds-dk"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/main/sap/cds-dk-8.4.1 branch from be6ae15 to 2fe4572 Compare November 12, 2024 10:01
@@ -26,7 +26,7 @@ async function createEntity(key: number) {
.stringProperty('someValue')
.dateProperty(moment(0))
.timeOfDayProperty({ hours: 1, minutes: 2, seconds: 3 })
.dataTimeOffsetDataTimeProperty(moment(0))
// .dataTimeOffsetDataTimeProperty(moment(0))
Copy link
Contributor

@deekshas8 deekshas8 Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This throws the error:

"message":"Value 2024-11-15T14:10:32.84Z is not a valid DateTime","target":"DataTimeOffsetDataTimeProperty","code":"400","@Common.numericSeverity":4

For DateTimeOffset, this is a valid format as per OData docs

@deekshas8 deekshas8 merged commit 156a9ce into main Nov 15, 2024
16 checks passed
@deekshas8 deekshas8 deleted the dependabot/npm_and_yarn/main/sap/cds-dk-8.4.1 branch November 15, 2024 15:27
@deekshas8 deekshas8 restored the dependabot/npm_and_yarn/main/sap/cds-dk-8.4.1 branch November 15, 2024 15:28
deekshas8 added a commit that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant