[WIP] v2.x - Rework SP request UUID generation to remove mutable constant #735
+36
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace the mutable RubySaml::Utils::UUID_PREFIX constant with `Settings.sp_uuid_prefix` - Make Authnrequest, etc. `uuid` attribute to be immutable. - Initialize Authnrequest, etc. `uuid` attribute when `create` is called, based on `Settings.sp_uuid_prefix`, not when instantiating the Ruby object.
johnnyshields
changed the title
johnnyshields
changed the title
|
@pitbulk would like to get your feedback on this. I am OK to keep the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the way SP request UUID generation is handled.
RubySaml::Utils::UUID_PREFIXconstant andset_prefixmethod withSettings.sp_uuid_prefixuuidattribute to be immutable.uuidattribute whencreateis called, based onSettings.sp_uuid_prefix, not when instantiating the Ruby object.