-
-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support frozen strings with REXML #728
base: master
Are you sure you want to change the base?
Support frozen strings with REXML #728
Conversation
@frederikspang I am pretty sure this is fixed on v2 already, but @pitbulk it might make sense to fix this on master anyway as it will is needed for Ruby 3.4 |
@johnnyshields I've adjusted some stuff from review. UUID_PREFIX is used as a constant, and |
@frederikspang yikes wow we were calling replace on a constant 🤦♂️ . The way you have it now with |
Changes are not compatible with ruby 2.X versions. @johnnyshields, for this, the v2 should be used instead. we should address the UUID_PREFIX on that brach. |
@pitbulk frozen string stuff is handled already on 2.x. This is a "backport" in case we want it on 1.x branch, but the alternative here would be to just close this PR and tell users they must use 2.x for Ruby 3.4+. Which is reasonable in my opinion. |
Mutable constant addressed here: #735 |
Tests are passing with
export RUBYOPT=--enable-frozen-string-literal