Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Mac packaging and wheel jobs to Sonoma #21984

Merged

Conversation

BetsyMcPhail
Copy link
Contributor

@BetsyMcPhail BetsyMcPhail commented Oct 2, 2024

Towards #21978


This change is Reviewable

Copy link
Contributor Author

@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@mwoehlke-kitware for review. Merge needs to be coordinated with Jenkins and drake-ci changes.

Reviewable status: LGTM missing from assignee mwoehlke-kitware, needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge", missing label for release notes (waiting on @BetsyMcPhail)

@BetsyMcPhail
Copy link
Contributor Author

@drake-jenkins-bot retest this please

1 similar comment
@BetsyMcPhail
Copy link
Contributor Author

@drake-jenkins-bot retest this please

Copy link
Contributor

@mwoehlke-kitware mwoehlke-kitware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, Ventura is still mentioned in .github/ISSUE_TEMPLATE/BUG.yml (Monterey, too!). Also in doc/_pages/installation.md which probably needs update?

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee mwoehlke-kitware, needs platform reviewer assigned, needs at least two assigned reviewers, missing label for release notes (waiting on @BetsyMcPhail)

Copy link
Contributor Author

@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, a follow-up PR removing all traces of Ventura is on its way soon. Just switching over packaging/wheel jobs and documentation for now.

Reviewable status: LGTM missing from assignee mwoehlke-kitware, needs platform reviewer assigned, needs at least two assigned reviewers, missing label for release notes (waiting on @BetsyMcPhail)

Copy link
Contributor Author

@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@rpoyner-tri for platform review tomorrow (per schedule)

Reviewable status: LGTM missing from assignees mwoehlke-kitware,rpoyner-tri(platform), missing label for release notes (waiting on @BetsyMcPhail)

Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: platform +@jwnimmer-tri -@rpoyner-tri .

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee mwoehlke-kitware, missing label for release notes (waiting on @BetsyMcPhail)

@jwnimmer-tri jwnimmer-tri added the release notes: none This pull request should not be mentioned in the release notes label Oct 7, 2024
Copy link
Contributor

@mwoehlke-kitware mwoehlke-kitware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees jwnimmer-tri(platform),mwoehlke-kitware

@jwnimmer-tri jwnimmer-tri merged commit 9ed5643 into RobotLocomotion:master Oct 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: none This pull request should not be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants