Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small tutorial updates #65

Merged
merged 2 commits into from
May 15, 2024
Merged

small tutorial updates #65

merged 2 commits into from
May 15, 2024

Conversation

enryH
Copy link
Member

@enryH enryH commented Dec 23, 2022

  • Only minor changes (paths and small wording suggestions)

Regarding the last step: Is the hyperparameter search run or not? I would say it should be at least mentioned how you would run the search here and how it is then picked up later, what do you think?

@enryH
Copy link
Member Author

enryH commented Dec 23, 2022

Is tutorial\results\identify_associations\results_sig_assoc.tsv overwritten when I ran both methods of the tutorial?

@enryH
Copy link
Member Author

enryH commented Dec 23, 2022

Okay yes. Just found issue #60 - I guess we need to decide if we want to fix this before/on the 2nd of January @simonrasmu @ri-heme

@ri-heme
Copy link
Collaborator

ri-heme commented Dec 23, 2022

Is tutorial\results\identify_associations\results_sig_assoc.tsv overwritten when I ran both methods of the tutorial?

Yes. I guess an easy fix is to just give them separate file names. I also thought that users would probably want to use a different output folder, which would avoid this situation

@ri-heme
Copy link
Collaborator

ri-heme commented Dec 23, 2022

Regarding the last step: Is the hyperparameter search run or not? I would say it should be at least mentioned how you would run the search here and how it is then picked up later, what do you think?

In the introductory tutorial, hyperparameter search is only mentioned. I made a second tutorial for it: https://move-dl.readthedocs.io/tutorial/model_tuning.html

It needs to be updated though, and I also wanted to add a preview of the table generated after hyperparameter tuning and code to make a plot from it.

@ri-heme ri-heme merged commit 92bced0 into main May 15, 2024
@ri-heme ri-heme deleted the tut-updated branch May 15, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants